-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Panel: Hide empty menus #27141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-szabo97
requested review from
mattwiebe,
jameskoster,
vindl,
Copons,
jeyip,
noahtallen and
Addison-Stavlo
November 20, 2020 12:59
Size Change: +82 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
vindl
approved these changes
Nov 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jameskoster
approved these changes
Nov 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected :)
david-szabo97
force-pushed
the
add/navigation-panel-hide-empty-menus
branch
from
November 23, 2020 17:23
937e4cf
to
07bdf7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hides empty menus in the navigation panel. Namely
Templates -> Pages
andTemplates -> Posts
.How has this been tested?
Since 2021-blocks theme includes templates for both Pages and Posts, we need to delete one of them. (Easiest way is using a file manager plugin and navigating to
wp-content/themes/twentytwentyone-blocks/block-templates
and deletepage.html
then delete your auto-draft in the Templates. This should hidePages
. You can do the same forPosts
with thesingle.html
file.Screenshots
Both pages and posts are hidden
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: