Reusable Blocks: Change from store name provided as a string to store definition

[grzim]

Description

Regarding #27088
Change from store name provided as a string to store definition applied

How has this been tested?

Not tested yet

Types of changes

Code refactor (non-breaking change)

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.

[gziolo]

This is surprising to see a cyclic dependency between store/index.js and store/controls.js. Would it be possible to access somehow dispatch from the current store instead? /cc @adamziel

[adamziel]

@gziolo The control needs to dispatch data on its own store so it's not easily avoidable. I think the only way of avoiding circular dependency would be not refactoring this file and just leaving the core/reusable-blocks string as it was before, or perhaps using the same constant as store/index.js, only imported from e.g. store/constants.js. This is going to be a general theme in plenty of registry actions and selectors too - we should address all those cases in the same way and either accept the circular dependency (it shouldn't break anything in this case) or use string to refer to the store from the same package.

[gziolo]

True, reusing the constant (internal to the local store's implementation) sounds like a good way of handling this particular case 👍

[gziolo]

It looks like we can now remove the following statements from some packages:

import '@wordpress/reusable-blocks';

@adamziel, is there anything I could miss that justifies those imports after the refactoring proposed?

[gziolo]

@grzim, thank you for opening this PR. In general, this looks good, I had some question to @adamziel who according to git authored @wordpress/reusable-blocks package.

[gziolo]

This PR is good, we can always open a follow-up to address the usage in controls.

[github-actions]

Congratulations on your first merged pull request, @grzim! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!