Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Support: Separate opt in for font style and weight options #26844

Merged
merged 6 commits into from
Nov 24, 2020
Merged

Block Support: Separate opt in for font style and weight options #26844

merged 6 commits into from
Nov 24, 2020

Commits on Nov 23, 2020

  1. Separate opt in for font style and weight block support 

    Updates the recently added font appearance block support to separate the style and weight aspects in terms of opting in via block.json. This required:

* Updating the detection of support opt in within typography tools
* Updating the UI control to handle the situation when only one option is opted into

This change also includes adding translation for the combined UI option labels and extracting concerns of how the selections are stored within style attributes from the UI control.
    @aaronrobertshaw
    aaronrobertshaw committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    1047131 View commit details
    Browse the repository at this point in the history

  2. Replace regex use to extract CSS variable value

    @aaronrobertshaw
    aaronrobertshaw committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    c8637c4 View commit details
    Browse the repository at this point in the history

  3. Change font style or weight disabling in control

    @aaronrobertshaw
    aaronrobertshaw committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    779d120 View commit details
    Browse the repository at this point in the history

  4. Separate font style/weight in theme json class

    @aaronrobertshaw
    aaronrobertshaw committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    6a4248e View commit details
    Browse the repository at this point in the history

  5. Use dedicated value property in presets

    @aaronrobertshaw
    aaronrobertshaw committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    59a3e00 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2020

  1. Add font style to theme-json doc

    @aaronrobertshaw
    aaronrobertshaw committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    b86e08c View commit details
    Browse the repository at this point in the history