[edit-widgets beta] Preload widgets #24855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of starting with XHR for each widget)
adamziel
added
[Feature] Widgets Screen
adamziel
requested review from
ajitbohra,
Soean,
spacedmonkey,
talldan and
youknowriad
as code owners
adamziel
commented
Aug 27, 2020
| @@ -351,6 +351,17 @@ public static function get_widgets( $sidebar_id ) { | |||
| $widget['id_base'] = $instance->id_base; | |||
| } | |||
|
|
|||
| if ( $request['context'] === 'edit' && isset( $wp_registered_widget_controls[ $widget_id ]['callback'] ) ) { | |||
There was a problem hiding this comment.
I don't like checking for context here, but that's a nested field and the core only filters top-level fields based on the context. It seems like an opportunity for a bugfix/new feature :-)
There was a problem hiding this comment.
We also should really be moving this to a /widgets controller ASAP.
There was a problem hiding this comment.
Spin this in another issue? I would love this /widgets endpoint 👍
20 tasks
|
Size Change: +73 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
6 tasks
draganescu
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the experimental widgets screen so that it's pre-populated with legacy widgets on the initial load.
Before: (flash of blank state, issuing multiple XHRs)
After: (all forms loaded from the very beginning)
How has this been tested?
/widgets.php.Types of changes
New feature (non-breaking change which adds functionality)
Checklist: