-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add character count to info panel #24823
Add character count to info panel #24823
Conversation
Adding @jasmussen and @shaunandrews as (design) reviewers 👋 |
I like the list view! @ockham Should we discuss the list view in another PR? We can get this merged as-is then implement the list view in another PR and see what others think about it. |
Sounds good! |
This may sound like a silly question, but... what is the use of this? |
The issue that this PR addresses (#24538) has one:
|
This merged and now we have a bunch of whitespace. I think we could just change the
Something like this: |
Did this get reviewed from polyglots? Does the character count work for languages like Japanese? Wouldn't word count and character count be the same there? That's why #14589 did show either character count or word count, depending on the locale. |
In a Japanese install of WP, the default word count setting is Below is this PR on a Japanese install. It's counting each letter of ASCII words as one word (e.g. "WordPress" is counted as 9 words) for word count. When I switch the site language to English, I get this. Until there is a space or newline, a whole paragraph is counted as one word. Google docs count words in a similar way as an English install of WP. Microsoft Word gives me very detailed stats. They are counting an Asian character as one word, and adding that to the count of ASCII words. This seems perfect... only if we want to go that far. I feel the current WP English setting & Google Docs approach is ok, and I personally want to see both character and word count. It's useful when I'm writing mixed text using Asian & non-Asian characters, which happens a lot. The text used for the above samples (a section from WP 5.5 About page):
|
@aristath F.Y.I
ScreenshotsHow Sentences Look LikeA description of WordPress in Japanese(Wikipedia) A description of WordPress in Simplified Chinese(Wikipedia) How to Estimate the Amount of DocumentA list of submission requirements of Science fiction short stories. Requirements of Japanese Sci-Fi contest. Hope it helps. |
Thank you @fumikito! I didn't know that, it does help me understand why we needed the character count 👍 |
Description
Closes: #24538
Adds "Characters" count to the document information panel.
How has this been tested?
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: