Add state for storing dragged block client ids to block-editor store #24782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Feature] Drag and Drop
talldan
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
mkaz and
youknowriad
as code owners
talldan
requested review from
tellthemachines,
noisysocks,
kevin940726 and
draganescu
|
Size Change: +99 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
kevin940726
reviewed
Aug 26, 2020
| * | ||
| * @param {Object} state Global application state. | ||
| * | ||
| * @return {string[]} Array of dragged block client ids. |
There was a problem hiding this comment.
It could return null if not dragging blocks. Should we return [] or null in this case? :🤔. I feel like [] would be simpler to indicate that there's no blocks being dragged, and unify the type. We just have to check the length attribute in isDraggingBlocks.
There was a problem hiding this comment.
Yep, makes sense, fixed in 680714b 👍
draganescu
approved these changes
Aug 26, 2020
kevin940726
approved these changes
Aug 26, 2020
… block-editor store
Co-authored-by: Kai Hao <kevin830726@gmail.com>
talldan
force-pushed
the
add/block-editor-state-for-dragged-block-client-id
branch
from
91d2892 to
fd9ef54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds state for storing dragged client ids to block editor store.
This is used in the PR for List View drag and drop (#23952).
In List View we need a way to determine whether a dragged block can be nested as an inner block under a parent. For normal drag and drop,
InnerBlocksas a drop zone and handles that logic, but in List View there's no renderedInnerBlockscomponent (because List View doesn't render a block'seditfunction). Storing this state allows us to do a check likecanInsertBlocks( draggedBlocks, parentClientId ), which wasn't possible before.Beyond List View, this may also be a step towards improving drop zones in the editor canvas—the dragged block ids could be used to only show valid drop zones when dragging.
How has this been tested?
Added unit tests.
For manual testing, dragging and dropping blocks should behave the same as in
master.Types of changes
Non-breaking new API
Checklist: