Update some comments for drag-and-drop of navigation submenus#24708
Merged
Update some comments for drag-and-drop of navigation submenus#24708
Conversation
kevin940726
requested review from
Soean,
ajitbohra,
ellatrix,
talldan and
youknowriad
as code owners
kevin940726
added
[Block] Navigation
|
Size Change: +2.91 kB (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
9 tasks
talldan
reviewed
Aug 25, 2020
talldan
approved these changes
Aug 26, 2020
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
Thanks for addressing the comments ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continued from #24479 (review), update some comments in the original PR.
Also enable DnD inside submenus in navigation screen as suggested here: #24479 (comment).
Types of changes
New featureChecklist: