Navigation: Preload Navigation screen API requests#24672
Closed
noisysocks wants to merge 1 commit intomasterfrom
Closed
Navigation: Preload Navigation screen API requests#24672noisysocks wants to merge 1 commit intomasterfrom
noisysocks wants to merge 1 commit intomasterfrom
Conversation
Use wp.apiFetch.createPreloadingMiddleware to preload the innitial API requests made by the Navigation screen. This makes the screen appear quicker.
noisysocks
added
[Type] Performance
noisysocks
requested review from
TimothyBJacobs and
spacedmonkey
as code owners
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
talldan
reviewed
Aug 21, 2020
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
There seems to be a couple of (possibly caching?) bugs in this branch that I couldn't reproduce on master.
- When deleting the last/only menu, the screen briefly changes, but then the deleted menu re-appears.
- When no menus are present (delete your last menu and then reload the page) and creating a menu for the first time, the 'Create Menu' UI is still shown after the menu has been created.
Member
Author
Hm, bugger. I suspect the way we handle preloading in Gutenberg is flawed. We're caching requests at the Probably we'll have to look at implementing preloading at the Closing for now. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24642.
Use
wp.apiFetch.createPreloadingMiddlewareto preload the initial API requests made by the Navigation screen. This makes the screen appear quicker.To test