Skip to content

Update Template Part Block Placeholder Button Styles #24633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeyip merged 2 commits into from
Aug 18, 2020
Merged

Update Template Part Block Placeholder Button Styles #24633

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fdce36
Remove button group and button group styling
jeyip Aug 18, 2020
f00930b
Add tertiary styling to New template part button
jeyip Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions packages/block-library/src/template-part/edit/placeholder/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,7 @@ import { __ } from '@wordpress/i18n';
import { useState, useCallback } from '@wordpress/element';
import { useDispatch } from '@wordpress/data';
import { cleanForSlug } from '@wordpress/url';
import {
Placeholder,
Dropdown,
ButtonGroup,
Button,
} from '@wordpress/components';
import { Placeholder, Dropdown, Button } from '@wordpress/components';
import { blockDefault } from '@wordpress/icons';
import { __experimentalSearchForm as SearchForm } from '@wordpress/block-editor';

Expand Down Expand Up @@ -54,18 +49,18 @@ export default function TemplatePartPlaceholder( { setAttributes } ) {
contentClassName="wp-block-template-part__placeholder-preview-dropdown-content"
position="bottom right left"
renderToggle={ ( { isOpen, onToggle } ) => (
<ButtonGroup>
<>
<Button
isPrimary
onClick={ onToggle }
aria-expanded={ isOpen }
>
{ __( 'Choose existing' ) }
</Button>
<Button onClick={ onCreate }>
<Button isTertiary onClick={ onCreate }>
{ __( 'New template part' ) }
</Button>
</ButtonGroup>
</>
) }
renderContent={ () => (
<>
Expand Down