-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a maximum height to the preview of the long blocks #24493
Adding a maximum height to the preview of the long blocks #24493
Conversation
Added a maximum height for the preview of large blocks
…r minus the top position of the preview window
While this fixes the inserter, style switcher is still broken, I suggest you use max-height |
What should be the maximum height for the preview of the styles? I chose it to be 160px, which is a double of its minimum height of 80px. Would that be enough? |
@aktasfatih the design of the style previews is likely going to change. I think for now a max height of |
Should I remove the change for style previews or keep it? And what do you think about the preview of the main blocks? Thanks! |
I am unsure if it's necessary yet. I haven't encountered long blocks with previews so it's hard to say
The main block preview looks ace! Nice work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
Closes #24484
How has this been tested?
Types of changes
I added a maximum height of 700px to the preview of the blocksChecklist: