Implement the custom classname support hook in the server #24483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Block API
youknowriad
requested review from
oandregal,
jorgefilipecosta and
Addison-Stavlo
youknowriad
requested review from
ajitbohra,
Soean,
spacedmonkey,
talldan and
TimothyBJacobs
as code owners
youknowriad
force-pushed
the
add/custom-classname-server
branch
from
77141d7 to
7e93d38
Compare
|
Size Change: +3.33 kB (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
youknowriad
added
the
Needs Dev Note
There was a problem hiding this comment.
Tested this out on 'Site Title' block and can verify the custom class name is now applied correctly on the front-end! 🎉
This looks good to me, as it follows the standard convention for the rest of the supported styles (minus the slight change to default true since it is an opt-out setting?)
I assume we should probably expand the test file to include this as well? Generally for each style I have added 1 test to ensure the style is added when expected, 1 test to ensure the style isnt added when unsupported, and generally update the all-applied test to include it as well. With a lot of styles being supported this convention is growing the file quite a bit, so maybe you have other ideas? Although, it is simple enough to create new ones with copy/paste and minimal alteration as the format is very similar for them all. 🤷♀️
|
Thanks for testing @Addison-Stavlo I've added a unit test. |
Addison-Stavlo
approved these changes
Aug 13, 2020
tellthemachines
removed
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In different dynamic blocks, we support custom class names in the server in an Adhoc way and now that we have the block-supports handling on the server as well, this PR implements it automatically for all these blocks.
There are still other hooks that could benefit from a similar approach: anchor, generated classname.
Testing instructions
Check that custom classnames work for these blocks (editor and frontend)