Try: Fix admin-theme colors in the canvas. #24408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -991 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Aug 6, 2020
| // It is important to include these styles in all built stylesheets | ||
| // This allows to CSS variables post CSS plugin to generate fallbacks. | ||
| :root { | ||
| @include admin-scheme(#007cba); |
There was a problem hiding this comment.
interesting!
If we remove this from here, we need to move it to all the edit-* stylesheets + list-reusable-blocks.
Alternatively, we can define the fallback variables in the config of the PostCSS CSS variables plugin.
There was a problem hiding this comment.
I believe it's already there, through the mixin:
And that mixin is something like
@mixin wordpress-admin-schemes() {
body.admin-color-light {
@include admin-scheme(#0085ba);
}
...
}
I'm happy to test the failure condition of removing this if there's an easy way to do it?
There was a problem hiding this comment.
the fallback can be tested on IE11 or you can just check that anytime the variable is used on the produced CSS, there's always a default value applied.
Thinking again, moving this to edit-* won't solve the issue of fallbacks because the fallback won't be applied to stylesheets like "components"... So the only way is to actually define the fallback in the plugin's config.
There was a problem hiding this comment.
How do we best move forward with this one?
youknowriad
force-pushed
the
try/fix-color-inheritance
branch
from
dc4e054 to
6c9969b
Compare
|
I pushed a fix that takes into account the fallbacks. It should be good to go now. |
youknowriad
approved these changes
Aug 28, 2020
|
You're the best, Riad. Thank you. |
adrianduffell
added a commit
to woocommerce/woocommerce-admin
that referenced
this pull request
Oct 23, 2020
The <Button> component styles from @wordpress/components were missing color styles. This is due to a change in @wordpress/base-styles where a different technique for providing the default button colors was implemented in WordPress/gutenberg#24408. As a temporary measure, this restores the previous code by copying it here directly.
adrianduffell
added a commit
to woocommerce/woocommerce-admin
that referenced
this pull request
Oct 29, 2020
The <Button> component styles from @wordpress/components were missing color styles. This is due to a change in @wordpress/base-styles where a different technique for providing the default button colors was implemented in WordPress/gutenberg#24408. As a temporary measure, this restores the previous code by copying it here directly.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The globally set CSS variables for the WP-admin color scheme were overridden, just inside the editing canvas.
Before:
After:
This is a draft PR because based on the code comment, it looks like the rule removed was necessary. I'd appreciate advice on where to move it.