Register the block attributes server-side for blocks with support flags #24400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Block API
youknowriad
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
Addison-Stavlo
approved these changes
Aug 6, 2020
| 'type' => 'string', | ||
| 'enum' => array( 'left', 'center', 'right', 'wide', 'full', '' ), | ||
| ); | ||
| if ( ! array_key_exists( 'align', $block_type->attributes ) ) { |
There was a problem hiding this comment.
Ah, yes! Good addition we missed in the last one. This makes sense to not define if it is already defined.
| $block_type->attributes = array(); | ||
| } | ||
|
|
||
| if ( $has_text_colors_support && ! array_key_exists( 'style', $block_type->attributes ) ) { |
There was a problem hiding this comment.
This may be more readable if we use $color_support instead of $has_text_colors_support (or a comment), since the style attribute needs to be initialized for custom values of all the different items that can have color support.
At first glance reading it I thought "why are we only defining the style object for text colors?", but then realized that none of the others can be supported without text color support anyways. So it still looks correct from a functionality standpoint!
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues on top of #24351 to register the missing attributes for the colors and typography support flags.
This doesn't have any impact on Core blocks because Core blocks with these flags don't use
ServerSideRender. Nonetheless, it is important to register those attributes for third-party blocks and for consistency.