Fix link color style property name in global styles #24296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
the
Global Styles
|
Size Change: +24 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jul 30, 2020
| '--wp--style--color--link' => array( '__experimentalColor', 'linkColor' ), | ||
| 'background-color' => array( '__experimentalColor' ), | ||
| 'background' => array( '__experimentalColor', 'gradients' ), | ||
| 'block-align' => array( 'align' ), |
There was a problem hiding this comment.
This doesn't make sense for me, though it's not introduced in this particular PR.
There was a problem hiding this comment.
I've noticed it as well, made a note to review later.
There was a problem hiding this comment.
Heya! Sorry, that was my doing... does block align not belong in this function in general?
Its being used for checking if a block as align hook support here:
Line 421 in 1087121
but I can remove it from this function and just check if the block_type has the align flag there instead if that makes more sense? I currently have #24300 open in this area to add support for default values and can update this there if needed. (Also I wouldn't mind any input/review on that PR, I didn't realize we missed the case for default values when we originally added those functions in #23007.)
There was a problem hiding this comment.
Riad already proposed an alternative at #24351
youknowriad
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #24250
This fixes the name of the style property for link color + sorts them alphabetically.