Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport GB 8.6 fixes to WP trunk #24068

Merged
merged 23 commits into from
Jul 20, 2020
Merged

Backport GB 8.6 fixes to WP trunk #24068

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
1424ce0
Fix drag and drop for aligned blocks (#23916)
talldan Jul 14, 2020
7e47aca
Fix drag and drop to empty block lists (#23923)
talldan Jul 14, 2020
6ff8d78
Optimize selector calls (#23930)
youknowriad Jul 15, 2020
caea9f1
Update Line-Height Settings for opt-in (rather than opt-out) (#23904)
Jul 15, 2020
c11ace4
Use composite pattern to improve keyboard navigation on the inserter …
youknowriad Jul 15, 2020
757ec73
persist tooltip on hover (#23959)
ntsekouras Jul 15, 2020
b170159
Make the line height and custom units theme support flags consistent …
youknowriad Jul 15, 2020
156e20a
Remove messaging that suggests contacting administrator for users wit…
StevenDufresne Jul 15, 2020
e5400d9
Remove core-embed/hulu (#23984)
tacitonic Jul 16, 2020
0777392
Fix block icon mouse out gesture issue. (#23980)
ZebulanStanphill Jul 16, 2020
5cd6da2
Fix edited Classic block's content deletion when switching to Code ed…
ntsekouras Jul 16, 2020
1e82285
Fix blocks dropping incorrectly in nested blocks (#23950)
talldan Jul 16, 2020
60ae848
Image: Add the ability for a plugin to disable Image Editor (#23966)
mkaz Jul 20, 2020
9e09f3c
Components: Fix Toolbar arrow key navigation in RTL contexts (#24043)
diegohaz Jul 20, 2020
a98ed29
RichText: restore aria-multiline (#24041)
ellatrix Jul 20, 2020
3c2507a
Fix block wrapper selector (#23991)
ellatrix Jul 20, 2020
39ebeb5
Prevent JavaScript error when using arrow navigation in URLInput (#24…
youknowriad Jul 20, 2020
66d1d2d
Editor: Fix block highlight rendering after block is moved (#23425)
Jul 20, 2020
e6789f0
Fix Copy block button focus loss and try to remove the visually hidde…
afercia Jul 20, 2020
436373a
Fix Inserter on the widgets screen (#24045)
youknowriad Jul 20, 2020
83cecf0
Use CSS variable for 'ui.brand' and 'ui.borderFocus' colors (#23936)
Jul 20, 2020
76f3bb2
Inserter: fix line to show again (#20792)
ellatrix Jul 20, 2020
0a9f997
Rename color value ui.brand to ui.theme. Hardcode color variable fall…
Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix drag and drop to empty block lists (#23923)
  • Loading branch information
@talldan @ellatrix
talldan authored and ellatrix committed Jul 20, 2020
commit 7e47acae67f8384da4528374e1c72688af331238
7 changes: 2 additions & 5 deletions packages/block-editor/src/components/use-block-drop-zone/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,17 +322,14 @@ export default function useBlockDropZone( {
useEffect( () => {
if ( position ) {
const blockElements = Array.from( element.current.children );

const targetIndex = getNearestBlockIndex(
blockElements,
position,
orientation
);

if ( targetIndex === undefined ) {
return;
}

setTargetBlockIndex( targetIndex );
setTargetBlockIndex( targetIndex === undefined ? 0 : targetIndex );
}
}, [ position ] );

Expand Down