Block Patterns: Override patterns that were registered by Core #24004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Type] Bug
ockham
requested review from
youknowriad,
mapk,
vindl,
kjellr,
enriquesanchez,
noahtallen and
Addison-Stavlo
ockham
commented
Jul 16, 2020
|
Size Change: +52 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
|
Tests are still failing 😕 Investigating... |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unconditionally register Gutenberg's block patterns, potentially overriding ones that were registered by Core.
This is to make sure that Gutenberg is using its own block patterns (rather than Core's), since they might have changes that haven't been synced to Core yet.
Specifically, this fixes #23996.
How has this been tested?
Easiest way: Verify that the "Admin - 4" GH Action goes green.
More difficult: Test locally by using a
.wp-env.override.jsonthat links to a current WP snapshot (rather than a released version), and runnpm run test-e2e -- packages/e2e-tests/specs/editor/various/adding-patterns.test.js. Or insert the "Two Buttons" block pattern in the editor, and verify that the default button labels areGet startedandLearn more, rather thanButton OneandButton Two.Types of changes
Bug fix.
Checklist: