Build: Make the watch rate slower to avoid using a lot of CPU while developing #23998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Build Tooling
mcsf
changed the title
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
|
In your testing, does #24001 lessen the need for this change? If so, how significantly? I'm wondering if the change to 500 ms could worsen the experience of Save -> Wait for recompile -> Reload page. I'm also wondering if certain text editors can contribute by e.g. using certain swap files or autosaving methods that trigger webpack more frequently. |
|
I didn't test properly tbh. My reasoning is that I'd rather wait 2 seconds when I save a file to refresh instead of having the CPU go crazy when I switch branches. I have no data to back this up. |
|
This is worth trying out. I also wouldn't mind having an environment variable to override this. |
|
Just going to merge this, let see if folks notice any inconvenience after that. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default it's 200ms, I'm using 500ms now but I believe we can also consider a higher number to take care of our CPUs.