-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E Tests: Remove duplicate blocks in setup file. #23981
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenDufresne
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
July 16, 2020 03:50
StevenDufresne
changed the title
E2E Tests: Remove duplicate blocks.
E2E Tests: Remove duplicate blocks in setup file.
Jul 16, 2020
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
Fixes #22820 |
talldan
added
[Type] Task
Issues or PRs that have been broken down into an individual action to take
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
labels
Jul 16, 2020
talldan
approved these changes
Jul 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
[Type] Task
Issues or PRs that have been broken down into an individual action to take
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove duplicate code block in e2e test setup that handles wpnonce messages.
The same code was introduced in: 256f67c and b448074.
You can verify here: https://github.com/WordPress/gutenberg/blame/master/packages/e2e-tests/config/setup-test-framework.js#L132
How has this been tested?
Not sure what the proper test would be.
Types of changes
Just removes the duplicate block.
Checklist: