Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist tooltips on hover #23959

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Persist tooltips on hover #23959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/components/src/tooltip/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
font-size: 12px;
box-shadow: none;

// This prevents quickly hovering the tooltip from blocking hovering something else.
pointer-events: none;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasmussen do you remember why we add this? (It was added on the original G2 branch).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the comment, it looks like it was added to make the tooltip "invisible" to a cursor so a user wouldn't accidentally click it when trying to click something else in the UI or on the canvas.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Michael is right, yes. If you hover a button and see a tooltip, that might cover a button immediately above it, and if you quickly click there to click that button, you should be able to.


> div {
padding: $grid-unit-05 $grid-unit-10;
}
Expand Down