Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored URLPopover to use React Hook #23918

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Refactored URLPopover to use React Hook #23918

merged 1 commit into from
Jul 14, 2020

Conversation

javidalkaruzi
Copy link
Contributor

Description

Related to #22890

Refactored URLPopover to use React Hooks

How has this been tested?

Tested using existing unit tests.
View changes in Storybook

Types of changes

Refactored URLPopover to use React Hooks

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

youknowriad
youknowriad approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for your help.

@youknowriad youknowriad merged commit d7af685 into WordPress:master Jul 14, 2020
@github-actions github-actions bot added this to the Gutenberg 8.6 milestone Jul 14, 2020
@ZebulanStanphill ZebulanStanphill added the [Type] Code Quality Issues or PRs that relate to code quality label Jul 14, 2020
@javidalkaruzi javidalkaruzi deleted the refactor/url-popover-component branch August 7, 2020 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees
No one assigned
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 8.6
Development

Successfully merging this pull request may close these issues.
3 participants
@javidalkaruzi @youknowriad @ZebulanStanphill