Adds basic documentation for the ToolbarButton component. #23909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuswetah
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
talldan
added
[Type] Developer Documentation
talldan
reviewed
Jul 14, 2020
talldan
reviewed
Jul 14, 2020
Elaborates more on ToolbarComponent information, mentioning its accessibility features. Co-authored-by: Daniel Richards <daniel.p.richards@gmail.com>
mkaz
requested changes
Jul 14, 2020
Proper documentation links on ToolbarButton page. Co-authored-by: Marcus Kazmierczak <marcus@mkaz.com>
Proper links usage on ToolbarButton documentation page. Co-authored-by: Marcus Kazmierczak <marcus@mkaz.com>
Proper links usage on ToolbarButton documentation page. Co-authored-by: Marcus Kazmierczak <marcus@mkaz.com>
Proper links usage on ToolbarButton documentation page. Co-authored-by: Marcus Kazmierczak <marcus@mkaz.com>
mkaz
approved these changes
Jul 14, 2020
diegohaz
approved these changes
Jul 14, 2020
|
Congratulations on your first merged pull request, @mateuswetah! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds basic documentation for the
ToolbarButtoncomponent. Any review and suggestion is welcome @mkaz, this is my first trial here.