Disable Page Template picker if modal layout picker is available #23872

chipsnyder · 2020-07-10T13:40:41Z

Fixes: wordpress-mobile/gutenberg-mobile#2419

Related PRs:

gutenberg-mobile: Disable Page Template picker if modal layout picker is available wordpress-mobile/gutenberg-mobile#2478
WordPress-iOS: Create Modal Layout Picker Container for new Gutenberg pages and feature flag for development wordpress-mobile/WordPress-iOS#14456

Description

This change enables the mobile editor to accept the capability modalLayoutPicker and based on that conditionally show or hide the Template Picker.

Android hasn't started Modal Layout Picker yet so this only needs to

How has this been tested?

To disable or enable the development version of Modal Layout Picker

Open the app from the build Create Modal Layout Picker Container for new Gutenberg pages and feature flag for development wordpress-mobile/WordPress-iOS#14456 (comment) or a local development build
- By default, the modal layout picker will be enabled.
- From the site page:
  - Click on your Gravatar.
  - Click on App Settings.
  - Click on Debug.
  - Toggle "Gutenberg Modal Layout Picker" to enable or disable the picker
    
    To toggle:

On iOS using the build options mentioned above

With Gutenberg Modal Layout Picker toggled on:
- Select to create a new page
- Expect to see the container for the new modal Layout Picker
- Select "Create Blank Page"
- Expect the current template picker to be hidden
With Gutenberg Modal Layout Picker toggled on:
- Select an existing page or draft without content (just a title)
- You should not see the new Modal Layout Picker
- Expect the current template picker to be hidden
With Gutenberg Modal Layout Picker toggled off:
- Select to create a new page
- You should not see the new Modal Layout Picker
- Expect the current template picker to be shown.
With Gutenberg Modal Layout Picker toggled off:
- Select an existing page or draft without content (just a title)
- You should not see the new Modal Layout Picker
- Expect the current template picker to be shown
With Gutenberg Modal Layout Picker toggled on or off:
- Select an existing page or draft with content
- Expect the current template picker to be hidden

On Android running a metro server or generating a build

Existing Blank Page
- Select an existing page or draft without content (just a title)
- Expect the current template picker to be shown
New Page
- Select to create a new page
- Expect the current template picker to be shown.
Existing Page
- Select an existing page or draft with content
- Expect the current template picker to be hidden

Types of changes

New feature

Checklist:

My code is tested.
My code follows the WordPress code style.
My code follows the accessibility standards.
My code has proper inline documentation.
I've included developer documentation if appropriate.
I've updated all React Native files affected by any refactorings/renamings in this PR.

github-actions · 2020-07-10T13:46:31Z

Size Change: +509 B (0%)

Total Size: 1.14 MB

Filename	Size	Change
`build/api-fetch/index.js`	3.39 kB	+1 B
`build/block-directory/index.js`	7.67 kB	-1 B
`build/block-editor/index.js`	115 kB	-15 B (0%)
`build/block-editor/style-rtl.css`	10.8 kB	+7 B (0%)
`build/block-editor/style.css`	10.8 kB	+4 B (0%)
`build/block-library/index.js`	132 kB	+37 B (0%)
`build/blocks/index.js`	48.2 kB	-1 B
`build/components/index.js`	199 kB	+72 B (0%)
`build/compose/index.js`	9.67 kB	-1 B
`build/core-data/index.js`	11.5 kB	+10 B (0%)
`build/data/index.js`	8.45 kB	-1 B
`build/edit-navigation/index.js`	10.8 kB	+13 B (0%)
`build/edit-post/index.js`	304 kB	+160 B (0%)
`build/edit-post/style-rtl.css`	5.61 kB	+20 B (0%)
`build/edit-post/style.css`	5.61 kB	+20 B (0%)
`build/edit-site/index.js`	16.8 kB	+170 B (1%)
`build/edit-site/style-rtl.css`	3.04 kB	+11 B (0%)
`build/edit-site/style.css`	3.04 kB	+12 B (0%)
`build/edit-widgets/index.js`	9.35 kB	-5 B (0%)
`build/editor/index.js`	45.1 kB	-1 B
`build/format-library/index.js`	7.72 kB	+1 B
`build/keyboard-shortcuts/index.js`	2.51 kB	+1 B
`build/plugins/index.js`	2.56 kB	-1 B
`build/rich-text/index.js`	13.9 kB	-1 B
`build/server-side-render/index.js`	2.71 kB	-2 B (0%)
`build/token-list/index.js`	1.27 kB	-1 B

ℹ️ View Unchanged

Filename	Size	Change
`build/a11y/index.js`	1.14 kB	0 B
`build/annotations/index.js`	3.67 kB	0 B
`build/autop/index.js`	2.82 kB	0 B
`build/blob/index.js`	620 B	0 B
`build/block-directory/style-rtl.css`	944 B	0 B
`build/block-directory/style.css`	945 B	0 B
`build/block-library/editor-rtl.css`	7.6 kB	0 B
`build/block-library/editor.css`	7.59 kB	0 B
`build/block-library/style-rtl.css`	7.77 kB	0 B
`build/block-library/style.css`	7.77 kB	0 B
`build/block-library/theme-rtl.css`	728 B	0 B
`build/block-library/theme.css`	729 B	0 B
`build/block-serialization-default-parser/index.js`	1.88 kB	0 B
`build/block-serialization-spec-parser/index.js`	3.1 kB	0 B
`build/components/style-rtl.css`	15.9 kB	0 B
`build/components/style.css`	15.8 kB	0 B
`build/data-controls/index.js`	1.29 kB	0 B
`build/date/index.js`	5.38 kB	0 B
`build/deprecated/index.js`	772 B	0 B
`build/dom-ready/index.js`	569 B	0 B
`build/dom/index.js`	3.23 kB	0 B
`build/edit-navigation/style-rtl.css`	1.08 kB	0 B
`build/edit-navigation/style.css`	1.08 kB	0 B
`build/edit-widgets/style-rtl.css`	2.45 kB	0 B
`build/edit-widgets/style.css`	2.45 kB	0 B
`build/editor/editor-styles-rtl.css`	537 B	0 B
`build/editor/editor-styles.css`	539 B	0 B
`build/editor/style-rtl.css`	3.78 kB	0 B
`build/editor/style.css`	3.78 kB	0 B
`build/element/index.js`	4.65 kB	0 B
`build/escape-html/index.js`	733 B	0 B
`build/format-library/style-rtl.css`	547 B	0 B
`build/format-library/style.css`	548 B	0 B
`build/hooks/index.js`	2.13 kB	0 B
`build/html-entities/index.js`	622 B	0 B
`build/i18n/index.js`	3.56 kB	0 B
`build/is-shallow-equal/index.js`	709 B	0 B
`build/keycodes/index.js`	1.94 kB	0 B
`build/list-reusable-blocks/index.js`	3.12 kB	0 B
`build/list-reusable-blocks/style-rtl.css`	476 B	0 B
`build/list-reusable-blocks/style.css`	476 B	0 B
`build/media-utils/index.js`	5.32 kB	0 B
`build/notices/index.js`	1.79 kB	0 B
`build/nux/index.js`	3.4 kB	0 B
`build/nux/style-rtl.css`	671 B	0 B
`build/nux/style.css`	668 B	0 B
`build/primitives/index.js`	1.4 kB	0 B
`build/priority-queue/index.js`	789 B	0 B
`build/redux-routine/index.js`	2.85 kB	0 B
`build/shortcode/index.js`	1.7 kB	0 B
`build/url/index.js`	4.06 kB	0 B
`build/viewport/index.js`	1.85 kB	0 B
`build/warning/index.js`	1.13 kB	0 B
`build/wordcount/index.js`	1.17 kB	0 B

_{compressed-size-action}

chipsnyder · 2020-07-10T17:35:40Z

The iOS PR is still in design review but this can be reviewed and merged separately from that.

packages/block-editor/src/components/page-template-picker/with-page-template-picker.native.js

geriux · 2020-07-14T16:49:44Z

Left some suggestions but it's working well with the test cases provided 🎉

chipsnyder · 2020-07-14T20:15:07Z

Thanks for the suggestion @geriux! This has been updated now

geriux

LGTM! Tested on iOS and Android.

Disable Page Template picker if modal layout picker is available

5d862b9

chipsnyder added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jul 10, 2020

chipsnyder added this to the Future milestone Jul 10, 2020

This was referenced Jul 10, 2020

Disable Page Template picker if modal layout picker is available wordpress-mobile/gutenberg-mobile#2478

Merged

Create Modal Layout Picker Container for new Gutenberg pages and feature flag for development wordpress-mobile/WordPress-iOS#14456

Closed

chipsnyder requested a review from geriux July 10, 2020 17:16

chipsnyder marked this pull request as ready for review July 10, 2020 17:34

geriux reviewed Jul 14, 2020

View reviewed changes

packages/block-editor/src/components/page-template-picker/with-page-template-picker.native.js Outdated Show resolved Hide resolved

geriux reviewed Jul 14, 2020

View reviewed changes

packages/block-editor/src/components/page-template-picker/with-page-template-picker.native.js Outdated Show resolved Hide resolved

Short circuit checks for page template picker checks

774504e

geriux approved these changes Jul 15, 2020

View reviewed changes

chipsnyder merged commit 4ae9ab1 into master Jul 15, 2020

chipsnyder deleted the mobile/issue/2419-MLPContainer branch July 15, 2020 14:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable Page Template picker if modal layout picker is available #23872

Disable Page Template picker if modal layout picker is available #23872

chipsnyder commented Jul 10, 2020 •

edited

Loading

github-actions bot commented Jul 10, 2020 •

edited

Loading

chipsnyder commented Jul 10, 2020

geriux commented Jul 14, 2020

chipsnyder commented Jul 14, 2020

geriux left a comment

Disable Page Template picker if modal layout picker is available #23872

Disable Page Template picker if modal layout picker is available #23872

Conversation

chipsnyder commented Jul 10, 2020 • edited Loading

Description

How has this been tested?

On iOS using the build options mentioned above

On Android running a metro server or generating a build

Types of changes

Checklist:

github-actions bot commented Jul 10, 2020 • edited Loading

chipsnyder commented Jul 10, 2020

geriux commented Jul 14, 2020

chipsnyder commented Jul 14, 2020

geriux left a comment

Choose a reason for hiding this comment

chipsnyder commented Jul 10, 2020 •

edited

Loading

github-actions bot commented Jul 10, 2020 •

edited

Loading