Updates text, buttons colors and labels #23855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enriquesanchez
added
the
[Feature] Patterns
enriquesanchez
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
kjellr
approved these changes
Jul 10, 2020
There was a problem hiding this comment.
Thanks, this seems like a definite improvement.
My only remaining question here is whether its important for us to follow our own guidelines about "primary" buttons in this case. Usually, we try not to have more than one primary blue button on page at a time. This is a little different, but it might make sense to make these black buttons just in case. What do you think?
Either way, not a dealbreaker. Thanks for the PR!
|
I think the primary buttons are totally fine here. They do feel a bit heavy in relation to the pattern, but I'm okay with it. |
youknowriad
added
the
Backport to WP 6.7 Beta/RC
6 tasks
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the text, the color of buttons, and their labels.
Before:
After:
