Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update colors and button labels of 'Three buttons' pattern #23849

Merged
merged 3 commits into from
Jul 15, 2020

Conversation

enriquesanchez
Copy link
Contributor

Updates background colors and labels of the 'Three buttons' pattern.

Before:
Screen Shot 2020-07-09 at 15 43 37

After:
Screen Shot 2020-07-09 at 15 43 25

@enriquesanchez enriquesanchez added the [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced label Jul 9, 2020
@enriquesanchez enriquesanchez self-assigned this Jul 9, 2020
@enriquesanchez enriquesanchez changed the title Update colors and button labels Update colors and button labels of 'Three buttons' pattern Jul 9, 2020
@github-actions
Copy link

github-actions bot commented Jul 9, 2020

Size Change: +527 B (0%)

Total Size: 1.14 MB

Filename Size Change
build/block-editor/index.js 115 kB +68 B (0%)
build/block-editor/style-rtl.css 10.8 kB +7 B (0%)
build/block-editor/style.css 10.8 kB +4 B (0%)
build/block-library/index.js 132 kB +36 B (0%)
build/blocks/index.js 48.2 kB -2 B (0%)
build/components/index.js 199 kB +16 B (0%)
build/core-data/index.js 11.5 kB +11 B (0%)
build/edit-post/index.js 304 kB +164 B (0%)
build/edit-post/style-rtl.css 5.6 kB +13 B (0%)
build/edit-post/style.css 5.6 kB +13 B (0%)
build/edit-site/index.js 16.8 kB +173 B (1%)
build/edit-site/style-rtl.css 3.04 kB +11 B (0%)
build/edit-site/style.css 3.04 kB +12 B (0%)
build/edit-widgets/index.js 9.35 kB -2 B (0%)
build/editor/index.js 45.1 kB +1 B
build/format-library/index.js 7.72 kB +3 B (0%)
build/keyboard-shortcuts/index.js 2.51 kB +1 B
build/media-utils/index.js 5.32 kB -1 B
build/rich-text/index.js 13.9 kB -1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.67 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 7.67 kB 0 B
build/block-directory/style-rtl.css 944 B 0 B
build/block-directory/style.css 945 B 0 B
build/block-library/editor-rtl.css 7.6 kB 0 B
build/block-library/editor.css 7.59 kB 0 B
build/block-library/style-rtl.css 7.77 kB 0 B
build/block-library/style.css 7.77 kB 0 B
build/block-library/theme-rtl.css 728 B 0 B
build/block-library/theme.css 729 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/components/style-rtl.css 15.9 kB 0 B
build/components/style.css 15.8 kB 0 B
build/compose/index.js 9.67 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.46 kB 0 B
build/date/index.js 5.38 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.23 kB 0 B
build/edit-navigation/index.js 10.8 kB 0 B
build/edit-navigation/style-rtl.css 1.08 kB 0 B
build/edit-navigation/style.css 1.08 kB 0 B
build/edit-widgets/style-rtl.css 2.45 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 537 B 0 B
build/editor/editor-styles.css 539 B 0 B
build/editor/style-rtl.css 3.78 kB 0 B
build/editor/style.css 3.78 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 709 B 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.4 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/server-side-render/index.js 2.71 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@kjellr
Copy link
Contributor

kjellr commented Jul 9, 2020

Perhaps it would make sense to source these from the WordPress palette? Maybe a blue one, a dark gray one, and a black one, or something like that? I don't expect that these colors will match many folks' sites out of the box.

@enriquesanchez
Copy link
Contributor Author

@kjellr Thanks for the feedback 🙏

I've updated the colors and also changed the button labels, let me know what you think.

Screen Shot 2020-07-09 at 18 37 14

@kjellr
Copy link
Contributor

kjellr commented Jul 10, 2020

Thanks! That seems pretty good. Is there a gray we can use that's a little closer to black? It looks a little bit like a disabled button to me.

@enriquesanchez
Copy link
Contributor Author

Thanks! That seems pretty good. Is there a gray we can use that's a little closer to black? It looks a little bit like a disabled button to me.

Thanks, @kjellr. The next darker shade in the WP color palette is #000. I feel these two colors now feel to close:

Screen Shot 2020-07-10 at 12 59 29

If we want to stick with the WP's colors, what if we tried different shaded of blue?

Screen Shot 2020-07-10 at 12 58 14

@mapk
Copy link
Contributor

mapk commented Jul 10, 2020

I like aligning with the WP color palette. Using a primary blue and black is a great idea. What if the third color is either the red, yellow, or green?
https://www.figma.com/file/e4tLacmlPuZV47l7901FEs/WordPress-Design-Library?node-id=2%3A0

@enriquesanchez
Copy link
Contributor Author

Here are a few variations using WP colors:

Screen Shot 2020-07-10 at 16 54 38

@youknowriad youknowriad added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jul 13, 2020
@kjellr
Copy link
Contributor

kjellr commented Jul 13, 2020

I'm a little stumped on these. The green one seems a little unusual and bright to me. Thinking cohesively about all of the block patterns, are there other colors we're using that we can pull in here instead?

@mapk
Copy link
Contributor

mapk commented Jul 13, 2020

I think 3 different colors is where this becomes too much. The one above with two colors from Enrique is visually stronger, but I think the grouping from the color is off. Try one where the "Authors" and "Publishers" are one color and "Books" are another. This way it relates the people together (authors and publishers) in the buttons, and the thing (books) as a separate button. What do you think?

@kjellr
Copy link
Contributor

kjellr commented Jul 13, 2020

Yeah, pulling three colors in here is difficult, and also may not reflect what users would end up doing.

@enriquesanchez
Copy link
Contributor Author

Agreed. Here's an example following Mark's suggestion:

Screen Shot 2020-07-13 at 13 50 41

@kjellr
Copy link
Contributor

kjellr commented Jul 13, 2020

Cool, I think that works, or else just having one blue button and two black after it. 👍

@enriquesanchez
Copy link
Contributor Author

@mapk @kjellr Thanks for all the feedback. Updated the colors and now should lool like this:

Screen Shot 2020-07-13 at 15 58 53

@mapk
Copy link
Contributor

mapk commented Jul 15, 2020

Here's a quick visual of @kjellr's suggestion for comparison sake.

switch-colors

Copy link
Contributor

@mapk mapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the two blue and the third button in black looks good. Let's roll.

@enriquesanchez enriquesanchez merged commit 232cb85 into master Jul 15, 2020
@enriquesanchez enriquesanchez deleted the update/three-buttons-pattern branch July 15, 2020 22:02
@github-actions github-actions bot added this to the Gutenberg 8.6 milestone Jul 15, 2020
@ellatrix ellatrix mentioned this pull request Jul 20, 2020
6 tasks
@youknowriad youknowriad removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants