Automation: Limit tests to not run on docs only changes #23834
Conversation
mkaz
added
the
[Package] Project management automation
|
The downside is the Github config to mark jobs as "Required". Now, we're forced to remove these tests from the required checks and just count on the "merger" to ensure these are passing before merging. |
|
@youknowriad That was going to be my question, I wanted to test if they get skipped does that mean they are considered passed or not. Is there a way to return true? |
|
@youknowriad We could remove the exclusion on the push to master check, but I suppose that doesn't really help, since its after the code got merged in. |
|
i removed these tests from the "required" ones. I think it's essentially a Github issue, they shouuld allow an option that says "all checks" are required (and all would be dependent on the PR) |
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
|
@youknowriad I'm not sure it is necessary to remove those tests as being "required". They didn't run on this PR, so they might just be skipped altogether. Worth testing to see, harder to rely on a person having to remember to check. |
It is necessary, otherwise you'll never be able to merge this PR (unless you're an admin). We had this issue already with other checks. |
#23535 Description
Add filters for E2E, mobile, and performance tests to not run on documentation only changes, defined by *.md files in /docs/ and /packages/ directory
How has this been tested?
Trying to figure out how to test. Ideally make a change to a markdown file and confirm that the E2E, Mobile, and Performance tests don't run, and don't block the PR.
Types of changes
Github Actions workflow update adding exclude paths