Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env: Only perform expensive install work when required #23809

Merged
merged 5 commits into from
Jul 14, 2020
Merged

Env: Only perform expensive install work when required #23809

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ec3042
Only install environment if config has changed
noahtallen Jul 9, 2020
a83db52
Update changelog
noahtallen Jul 9, 2020
9e9606e
Add unit tests
noahtallen Jul 9, 2020
c47cebd
Move local config earlier
noahtallen Jul 14, 2020
60a3c75
Fix JSdoc alignment
noahtallen Jul 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix JSdoc alignment
  • Loading branch information
@noahtallen
noahtallen committed Jul 14, 2020
commit 60a3c75eb89d2bc1d93954103099c4e8bd15d260
10 changes: 5 additions & 5 deletions packages/env/lib/cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ const CACHE_FILE_NAME = 'wp-env-cache.json';
* existing cache value. For example, we can use this to check if the configuration
* has changed in a new run of wp-env start.
*
* @param {string} key A unique identifier for the cache.
* @param {any} value The value to check against the existing cache.
* @param {string} key A unique identifier for the cache.
* @param {any} value The value to check against the existing cache.
* @param {WPEnvCacheOptions} options Parsing options
*
* @return {boolean} If true, the value is different from the cache which exists.
Expand All @@ -34,8 +34,8 @@ async function didCacheChange( key, value, options ) {
* file if it does not exist yet, and overwrites the existing cache value for the
* given key if it already exists.
*
* @param {string} key A unique identifier for the cache.
* @param {any} value The value to persist.
* @param {string} key A unique identifier for the cache.
* @param {any} value The value to persist.
* @param {WPEnvCacheOptions} options Parsing options
*/
async function setCache( key, value, options ) {
Expand All @@ -53,7 +53,7 @@ async function setCache( key, value, options ) {
* Returns undefined if the key does not exist or if the cache file has not been
* created yet.
*
* @param {string} key The unique identifier for the cache value.
* @param {string} key The unique identifier for the cache value.
* @param {WPEnvCacheOptions} options Parsing options
*
* @return {any?} The cache value. Undefined if it has not been set or if the cache
Expand Down