Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove navigation block styles #23678

Merged
merged 4 commits into from
Jul 7, 2020
Merged

Conversation

adamziel
Copy link
Contributor

@adamziel adamziel commented Jul 3, 2020

Description

Solves #22327 where we concluded the navigation block styles are not useful and should be removed.

How has this been tested?

  1. Go to post editor
  2. Add a new navigation block
  3. Confirm the background is transparent
  4. Add a few links and a few nested menus
  5. Confirm all the nested menus have light background
  6. Update the navigation block background
  7. Confirm the background was inherited by all the nested menus
  8. Ditto for font color
  9. Select the navigation block and confirm there are no style variations available in the block inspector
  10. Make sure the change works on the website after publishing the post

Screenshots

Zrzut ekranu 2020-07-3 o 14 41 59

Zrzut ekranu 2020-07-3 o 14 43 05

Types of changes

Breaking change - it will affect all existing styled blocks out in the wild.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@adamziel adamziel added the [Block] Navigation Affects the Navigation Block label Jul 3, 2020
@adamziel adamziel self-assigned this Jul 3, 2020
@ZebulanStanphill ZebulanStanphill added the [Type] Code Quality Issues or PRs that relate to code quality label Jul 3, 2020
@jasmussen
Copy link
Contributor

This feels a solid improvement. Lots of red, and overall just a better experience front and backend, we're really getting closer:

nav

It does remove light and dark mode. But given that those could easily be inherited by the theme itself, or even be customized using the color tools if need be, seems worth it.

👍 👍 on a design point of view, and CSS code looks good too. Happy to approve, but since it's a breaking change, I assume it will need a dev note or changelog entry or both?

Copy link
Member

@noisysocks noisysocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Removing the styles doesn't cause existing Navigation blocks out in the wild to no longer load. They will appear different, which is a breaking change, but since the Navigation block is experimental I think this is okay.

@adamziel adamziel force-pushed the update/remove-navigation-block-styles branch from 25b1729 to fd421ef Compare July 7, 2020 11:50
@github-actions
Copy link

github-actions bot commented Jul 7, 2020

Size Change: +5.43 kB (0%)

Total Size: 1.14 MB

Filename Size Change
build/annotations/index.js 3.67 kB -8 B (0%)
build/api-fetch/index.js 3.39 kB -8 B (0%)
build/block-editor/index.js 115 kB +5.34 kB (4%)
build/block-editor/style-rtl.css 10.8 kB +78 B (0%)
build/block-editor/style.css 10.8 kB +78 B (0%)
build/block-library/editor-rtl.css 7.54 kB -31 B (0%)
build/block-library/editor.css 7.54 kB -33 B (0%)
build/block-library/index.js 130 kB -47 B (0%)
build/block-library/style-rtl.css 7.75 kB -29 B (0%)
build/block-library/style.css 7.76 kB -25 B (0%)
build/block-serialization-default-parser/index.js 1.88 kB -2 B (0%)
build/blocks/index.js 48.2 kB -1 B
build/components/index.js 199 kB -3 B (0%)
build/compose/index.js 9.56 kB +4 B (0%)
build/core-data/index.js 11.4 kB +8 B (0%)
build/data-controls/index.js 1.29 kB -2 B (0%)
build/data/index.js 8.46 kB +11 B (0%)
build/edit-navigation/index.js 9.96 kB +28 B (0%)
build/edit-post/index.js 304 kB +101 B (0%)
build/edit-site/index.js 16.6 kB +17 B (0%)
build/edit-widgets/index.js 9.35 kB +1 B
build/editor/index.js 45 kB +3 B (0%)
build/element/index.js 4.65 kB -2 B (0%)
build/format-library/index.js 7.71 kB -13 B (0%)
build/hooks/index.js 2.13 kB -1 B
build/is-shallow-equal/index.js 709 B -1 B
build/keyboard-shortcuts/index.js 2.52 kB -1 B
build/keycodes/index.js 1.94 kB -2 B (0%)
build/list-reusable-blocks/index.js 3.12 kB -1 B
build/notices/index.js 1.79 kB -3 B (0%)
build/nux/index.js 3.4 kB -1 B
build/primitives/index.js 1.4 kB -6 B (0%)
build/priority-queue/index.js 789 B +1 B
build/redux-routine/index.js 2.85 kB -4 B (0%)
build/rich-text/index.js 13.9 kB -3 B (0%)
build/server-side-render/index.js 2.71 kB -2 B (0%)
build/shortcode/index.js 1.7 kB +1 B
build/token-list/index.js 1.27 kB -1 B
build/url/index.js 4.06 kB -4 B (0%)
build/warning/index.js 1.13 kB -4 B (0%)
build/wordcount/index.js 1.17 kB -1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 7.67 kB 0 B
build/block-directory/style-rtl.css 944 B 0 B
build/block-directory/style.css 945 B 0 B
build/block-library/theme-rtl.css 728 B 0 B
build/block-library/theme.css 729 B 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/components/style-rtl.css 15.8 kB 0 B
build/components/style.css 15.8 kB 0 B
build/date/index.js 5.38 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.23 kB 0 B
build/edit-navigation/style-rtl.css 1.02 kB 0 B
build/edit-navigation/style.css 1.02 kB 0 B
build/edit-post/style-rtl.css 5.57 kB 0 B
build/edit-post/style.css 5.57 kB 0 B
build/edit-site/style-rtl.css 3.03 kB 0 B
build/edit-site/style.css 3.03 kB 0 B
build/edit-widgets/style-rtl.css 2.45 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 537 B 0 B
build/editor/editor-styles.css 539 B 0 B
build/editor/style-rtl.css 3.78 kB 0 B
build/editor/style.css 3.78 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.32 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/viewport/index.js 1.85 kB 0 B

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants