Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use composite pattern to improve keyboard navigation on the inserter #23610

Merged
merged 5 commits into from
Jul 15, 2020
Merged

Use composite pattern to improve keyboard navigation on the inserter #23610

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
85a2a0c
Use composite pattern to improve keyboard navigation on the inserter
youknowriad Jul 1, 2020
ee899f9
Address a11y feedback
youknowriad Jul 2, 2020
c682202
Fix composite bug
youknowriad Jul 2, 2020
506de60
Use composite.unstable_sort and update html structure
diegohaz Jul 15, 2020
595010e
Fix end2end tests
youknowriad Jul 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix end2end tests
  • Loading branch information
@youknowriad
youknowriad committed Jul 15, 2020
commit 595010effdb11f7e274aace4c30cf11ad8e6c8b2
1 change: 0 additions & 1 deletion packages/e2e-tests/specs/editor/various/adding-blocks.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,6 @@ describe( 'adding blocks', () => {

// Tab to the block list
await page.keyboard.press( 'Tab' );
await page.keyboard.press( 'Tab' );

// Expect the block list to be the active element.
activeElementClassList = await page.evaluate(
Expand Down