Refactor Latest Comments block to use function component #23557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Block] Latest Comments
ntsekouras
reviewed
Jul 7, 2020
| <ToggleControl | ||
| label={ __( 'Display avatar' ) } | ||
| checked={ displayAvatar } | ||
| onChange={ () => |
There was a problem hiding this comment.
I believe you could keep the generic toggle function, since all three toggle on change like:
const toggleAttribute = ( propName ) => () =>
setAttributes( { [ propName ]: ! attributes[ propName ] } );
There was a problem hiding this comment.
I'm not convinced it would make much of a difference, performance-wise.
There was a problem hiding this comment.
It's more about reusability and not performance.
ntsekouras
reviewed
Jul 7, 2020
| displayAvatar, | ||
| displayDate, | ||
| displayExcerpt, | ||
| } = attributes; |
There was a problem hiding this comment.
You can destructure attributes in the above destructuring.
{ attributes, attributes: { commentsToshow, ....... } setAttributes }There was a problem hiding this comment.
Actually, it would be { attributes: { commentsToShow, (etc) }, setAttributes }. No need to duplicate attributes; actually, I think that would cause a linting error.
ZebulanStanphill
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #22890.
Types of changes
Refactor LatestComments to use function component.
Checklist: