Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link color component #22722

Merged
merged 1 commit into from
Jun 5, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 25 additions & 18 deletions lib/global-styles.php
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ function gutenberg_experimental_global_styles_get_block_data() {

$registry = WP_Block_Type_Registry::get_instance();
foreach ( $registry->get_all_registered() as $block_name => $block_type ) {
if ( ! is_array( $block_type->supports ) ) {
if ( empty( $block_type->supports ) || ! is_array( $block_type->supports ) ) {
continue;
}

Expand Down Expand Up @@ -375,11 +375,12 @@ function gutenberg_experimental_global_styles_get_block_data() {
*/
function gutenberg_experimental_global_styles_flatten_styles_tree( $styles ) {
$mappings = array(
'line-height' => array( 'typography', 'lineHeight' ),
'font-size' => array( 'typography', 'fontSize' ),
'background' => array( 'color', 'gradient' ),
'background-color' => array( 'color', 'background' ),
'color' => array( 'color', 'text' ),
'line-height' => array( 'typography', 'lineHeight' ),
'font-size' => array( 'typography', 'fontSize' ),
'background' => array( 'color', 'gradient' ),
'background-color' => array( 'color', 'background' ),
'color' => array( 'color', 'text' ),
'--wp--style--color--link' => array( 'color', 'link' ),
);

$result = array();
Expand Down Expand Up @@ -453,6 +454,16 @@ function gutenberg_experimental_global_styles_resolver( $tree ) {
function gutenberg_experimental_global_styles_resolver_styles( $block_selector, $block_supports, $block_styles ) {
$css_rule = '';
$css_declarations = '';

if ( gutenberg_experimental_global_styles_has_theme_json_support() ) {
// To support all themes, we added in the block-library stylesheet
// a style rule such as .has-link-color a { color: var(--wp--style--color--link, #00e); }
// so that existing link colors themes used didn't break.
// We add this here to make it work for themes that opt-in to theme.json
// In the future, we may do this differently.
$css_rule = 'a { color: var(--wp--style--color--link, #00e); }';
}

foreach ( $block_styles as $property => $value ) {
// Only convert to CSS:
//
Expand Down Expand Up @@ -553,9 +564,6 @@ function gutenberg_experimental_global_styles_get_stylesheet() {
* and enqueues the resulting stylesheet.
*/
function gutenberg_experimental_global_styles_enqueue_assets() {
if ( ! gutenberg_experimental_global_styles_has_theme_json_support() ) {
return;
}

$stylesheet = gutenberg_experimental_global_styles_get_stylesheet();

Expand All @@ -571,18 +579,17 @@ function gutenberg_experimental_global_styles_enqueue_assets() {
* @return array New block editor settings
*/
function gutenberg_experimental_global_styles_settings( $settings ) {
if ( ! gutenberg_experimental_global_styles_has_theme_json_support() ) {
jorgefilipecosta marked this conversation as resolved.
Show resolved Hide resolved
return $settings;
}

$settings['__experimentalGlobalStylesUserEntityId'] = gutenberg_experimental_global_styles_get_user_cpt_id();
if ( gutenberg_experimental_global_styles_has_theme_json_support() ) {
$settings['__experimentalGlobalStylesUserEntityId'] = gutenberg_experimental_global_styles_get_user_cpt_id();

$global_styles = gutenberg_experimental_global_styles_merge_trees(
gutenberg_experimental_global_styles_get_core(),
gutenberg_experimental_global_styles_get_theme()
);
$global_styles = gutenberg_experimental_global_styles_merge_trees(
gutenberg_experimental_global_styles_get_core(),
gutenberg_experimental_global_styles_get_theme()
);

$settings['__experimentalGlobalStylesBase'] = $global_styles;
$settings['__experimentalGlobalStylesBase'] = $global_styles;
}

// Add the styles for the editor via the settings
// so they get processed as if they were added via add_editor_styles:
Expand Down
49 changes: 49 additions & 0 deletions packages/block-editor/src/hooks/color.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,16 @@ export const COLOR_SUPPORT_KEY = '__experimentalColor';
const hasColorSupport = ( blockType ) =>
Platform.OS === 'web' && hasBlockSupport( blockType, COLOR_SUPPORT_KEY );

const hasLinkColorSupport = ( blockType ) => {
if ( Platform.OS !== 'web' ) {
return false;
}

const colorSupport = getBlockSupport( blockType, COLOR_SUPPORT_KEY );

return isObject( colorSupport ) && !! colorSupport.linkColor;
};

const hasGradientSupport = ( blockType ) => {
if ( Platform.OS !== 'web' ) {
return false;
Expand Down Expand Up @@ -121,6 +131,7 @@ export function addSaveProps( props, blockType, attributes ) {
backgroundColor ||
style?.color?.background ||
( hasGradient && ( gradient || style?.color?.gradient ) ),
'has-link-color': style?.color?.link,
}
);
props.className = newClassName ? newClassName : undefined;
Expand Down Expand Up @@ -151,6 +162,15 @@ export function addEditProps( settings ) {
return settings;
}

const getLinkColorFromAttributeValue = ( colors, value ) => {
const attributeParsed = /var:preset\|color\|(.+)/.exec( value );
if ( attributeParsed && attributeParsed[ 1 ] ) {
return getColorObjectByAttributeValues( colors, attributeParsed[ 1 ] )
.color;
}
return value;
};

/**
* Inspector control panel containing the color related configuration
*
Expand Down Expand Up @@ -245,6 +265,21 @@ export function ColorEdit( props ) {
};
};

const onChangeLinkColor = ( value ) => {
const colorObject = getColorObjectByColorValue( colors, value );
props.setAttributes( {
style: {
...props.attributes.style,
color: {
...props.attributes.style?.color,
link: colorObject?.slug
? `var:preset|color|${ colorObject.slug }`
: value,
},
},
} );
};

return (
<ColorPanel
enableContrastChecking={
Expand Down Expand Up @@ -275,6 +310,20 @@ export function ColorEdit( props ) {
? onChangeGradient
: undefined,
},
...( hasLinkColorSupport( blockName )
? [
{
label: __( 'Link Color' ),
onColorChange: onChangeLinkColor,
colorValue: getLinkColorFromAttributeValue(
colors,
style?.color?.link
),
clearable: !! props.attributes.style?.color
?.link,
},
]
: [] ),
] }
/>
);
Expand Down
19 changes: 17 additions & 2 deletions packages/block-editor/src/hooks/style.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import { has, get } from 'lodash';
import { has, get, startsWith } from 'lodash';

/**
* WordPress dependencies
Expand Down Expand Up @@ -42,6 +42,20 @@ const typographySupportKeys = [
const hasStyleSupport = ( blockType ) =>
styleSupportKeys.some( ( key ) => hasBlockSupport( blockType, key ) );

const VARIABLE_REFERENCE_PREFIX = 'var:';
const VARIABLE_PATH_SEPARATOR_TOKEN_ATTRIBUTE = '|';
const VARIABLE_PATH_SEPARATOR_TOKEN_STYLE = '--';
function compileStyleValue( uncompiledValue ) {
if ( startsWith( uncompiledValue, VARIABLE_REFERENCE_PREFIX ) ) {
const variable = uncompiledValue
.slice( VARIABLE_REFERENCE_PREFIX.length )
.split( VARIABLE_PATH_SEPARATOR_TOKEN_ATTRIBUTE )
.join( VARIABLE_PATH_SEPARATOR_TOKEN_STYLE );
return `var(--wp--${ variable })`;
}
return uncompiledValue;
}

/**
* Returns the inline styles to add depending on the style object
*
Expand All @@ -56,12 +70,13 @@ export function getInlineStyles( styles = {} ) {
background: [ 'color', 'gradient' ],
backgroundColor: [ 'color', 'background' ],
color: [ 'color', 'text' ],
'--wp--style--color--link': [ 'color', 'link' ],
};

const output = {};
Object.entries( mappings ).forEach( ( [ styleKey, objectKey ] ) => {
if ( has( styles, objectKey ) ) {
output[ styleKey ] = get( styles, objectKey );
output[ styleKey ] = compileStyleValue( get( styles, objectKey ) );
}
} );

Expand Down
3 changes: 2 additions & 1 deletion packages/block-library/src/columns/block.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
"html": false,
"lightBlockWrapper": true,
"__experimentalColor": {
"gradients": true
"gradients": true,
"linkColor": true
}
}
}
3 changes: 2 additions & 1 deletion packages/block-library/src/group/block.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
"html": false,
"lightBlockWrapper": true,
"__experimentalColor": {
"gradients": true
"gradients": true,
"linkColor": true
}
}
}
4 changes: 3 additions & 1 deletion packages/block-library/src/heading/block.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@
"anchor": true,
"className": false,
"lightBlockWrapper": true,
"__experimentalColor": true,
"__experimentalColor": {
"linkColor": true
},
"__experimentalFontSize": true,
"__experimentalLineHeight": true,
"__experimentalSelector": {
Expand Down
3 changes: 2 additions & 1 deletion packages/block-library/src/media-text/block.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@
],
"html": false,
"__experimentalColor": {
"gradients": true
"gradients": true,
"linkColor": true
}
}
}
4 changes: 3 additions & 1 deletion packages/block-library/src/paragraph/block.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@
"supports": {
"className": false,
"lightBlockWrapper": true,
"__experimentalColor": true,
"__experimentalColor": {
jorgefilipecosta marked this conversation as resolved.
Show resolved Hide resolved
"linkColor": true
},
"__experimentalFontSize": true,
"__experimentalLineHeight": true,
"__experimentalFeatures": {
Expand Down
5 changes: 4 additions & 1 deletion packages/block-library/src/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -234,8 +234,11 @@
background: linear-gradient(135deg,rgb(2,3,129) 0%,rgb(40,116,252) 100%);
}
/* stylelint-enable function-comma-space-after */
}

.has-link-color a {
color: var(--wp--style--color--link, #00e);
}
}

// Font sizes.
// The reason we add the editor class wrapper here is
Expand Down