Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Correct Buttons appender #22362

Merged
merged 1 commit into from
May 14, 2020
Merged

[RNMobile] Correct Buttons appender #22362

merged 1 commit into from
May 14, 2020

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented May 14, 2020 •
edited
Loading

Description

Fixes: wordpress-mobile/gutenberg-mobile#2227

[ANDROID only]
Fixed weird behaviour where after adding two buttons (only if these buttons take the whole width and appender has to drop below to the next line), appender (+) was not clickable.

How has this been tested?

  1. Add Buttons block
  2. Type Hello Hello Hello in first Button
  3. Press (+) appender to add next Button
  4. Expect that appender drop to the next line
  5. Press (+) appender
  6. Expect appender is clickable and another Button was added

Screenshots

before after
a_bug a_fix

Types of changes

Remove flex from appender.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@lukewalczak lukewalczak added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Block] Buttons Affects the Buttons Block labels May 14, 2020
@lukewalczak lukewalczak self-assigned this May 14, 2020
@github-actions
Copy link

Size Change: 0 B

Total Size: 832 kB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.02 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.59 kB 0 B
build/block-directory/style-rtl.css 764 B 0 B
build/block-directory/style.css 764 B 0 B
build/block-editor/index.js 104 kB 0 B
build/block-editor/style-rtl.css 10.8 kB 0 B
build/block-editor/style.css 10.8 kB 0 B
build/block-library/editor-rtl.css 7.25 kB 0 B
build/block-library/editor.css 7.25 kB 0 B
build/block-library/index.js 118 kB 0 B
build/block-library/style-rtl.css 7.48 kB 0 B
build/block-library/style.css 7.49 kB 0 B
build/block-library/theme-rtl.css 683 B 0 B
build/block-library/theme.css 685 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/index.js 182 kB 0 B
build/components/style-rtl.css 17.1 kB 0 B
build/components/style.css 17 kB 0 B
build/compose/index.js 6.68 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.43 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.1 kB 0 B
build/edit-navigation/index.js 5.6 kB 0 B
build/edit-navigation/style-rtl.css 618 B 0 B
build/edit-navigation/style.css 617 B 0 B
build/edit-post/index.js 28.2 kB 0 B
build/edit-post/style-rtl.css 12.2 kB 0 B
build/edit-post/style.css 12.2 kB 0 B
build/edit-site/index.js 12 kB 0 B
build/edit-site/style-rtl.css 5.22 kB 0 B
build/edit-site/style.css 5.22 kB 0 B
build/edit-widgets/index.js 7.86 kB 0 B
build/edit-widgets/style-rtl.css 4.69 kB 0 B
build/edit-widgets/style.css 4.69 kB 0 B
build/editor/editor-styles-rtl.css 425 B 0 B
build/editor/editor-styles.css 428 B 0 B
build/editor/index.js 44.3 kB 0 B
build/editor/style-rtl.css 5.07 kB 0 B
build/editor/style.css 5.08 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.63 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.51 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.13 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 5.29 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 788 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 14.8 kB 0 B
build/server-side-render/index.js 2.68 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.02 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@lukewalczak lukewalczak mentioned this pull request May 14, 2020
Closed
2 tasks
chipsnyder
chipsnyder approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on iPhone 11 and a Pixel 3a

@SergioEstevao SergioEstevao merged commit 6c66e2f into master May 14, 2020
@SergioEstevao SergioEstevao deleted the rnmobile/correct-buttons-appender branch May 14, 2020 17:59
@github-actions github-actions bot added this to the Gutenberg 8.2 milestone May 14, 2020
SergioEstevao pushed a commit that referenced this pull request May 14, 2020
@lukewalczak @SergioEstevao
Correct buttons appender (#22362)
069abf8
@mchowning mchowning mentioned this pull request May 14, 2020
Merged
5 tasks
mchowning added a commit that referenced this pull request May 26, 2020
@mchowning @SergioEstevao @lukewalczak
Integrate Mobile 1.28.1 release into master (#22607)
3c9deb4 
* RNMobile - Starter Page Templates - Portfolio: adds missing ids for galleries (#22321)

* Fix margin for the post-title (#22331)

* Fix margin for the post-title

Add 4px margin from the edges of the screen and adjust the alignment
of text.

* Only apply margins on the left and right edges.

* Correct buttons appender (#22362)

* Remove no longer necessary selection checks (#22500)

These are now handled on the native side

Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com>
Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipsnyder chipsnyder chipsnyder approved these changes

@geriux geriux Awaiting requested review from geriux

@dratwas dratwas Awaiting requested review from dratwas

Assignees

@lukewalczak lukewalczak

Labels
[Block] Buttons Affects the Buttons Block Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 8.2
Development

Successfully merging this pull request may close these issues.

[GlobalStep] [Android] At Create blog post, after adding two buttons "+"/appender symbol gets non-functional.
3 participants
@lukewalczak @chipsnyder @SergioEstevao