Fix centered buttons margins #21947
Merged
Fix centered buttons margins #21947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Regression
youknowriad
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
|
Size Change: -4 B (0%) Total Size: 816 kB
ℹ️ View Unchanged
|
aduth
reviewed
Apr 28, 2020
| @@ -1,10 +1,10 @@ | |||
| .wp-block[data-align="center"] .wp-block-button { | |||
| .wp-block[data-align="center"] > .wp-block-button { | |||
There was a problem hiding this comment.
Is it some sort of block nesting issue that was causing this? What's the difference in using direct descendent selector?
(My worry is that this "fixes" by just... never matching anything)
There was a problem hiding this comment.
yes, the alignment of the "buttons" block was being applied to the "button" block.
There was a problem hiding this comment.
The same issue could have happened if you rendered the buttons block inside a "centered" group (not sure that's possible in the UI)
aduth
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small regression introduced by #21822
The buttons margins were collapsed if the buttons block was centered.
Testing instructions