Format Library: add subscript and superscript #21819
Conversation
ellatrix
requested review from
etoledom,
jorgefilipecosta and
SergioEstevao
as code owners
|
Size Change: +315 B (0%) Total Size: 835 kB
ℹ️ View Unchanged
|
|
This is what I see:
Lovely, people are going to love this. I think it's also a good use of a dropdown. I'd put both options at the end below text color, though. And yes, we do need some icons. I made these:
I don't love them, but so long as we name them correctly, Subscript: Superscript: |
|
@jasmussen The icons look good, but I think that when text is selected, the subscript and superscript icons should appear to the right of the hyperlink button. |
This doesn't scale very well to narrow contexts, and since you have to select something to make it bold would be barely different from having them there all the time. Putting them in the drop-down is an effort to strike the balance between having the feature available, but recognizing that it's a feature you'll use rarely, unlike bold and italic. This is always a difficult balance to find, but I think it's the right balance. |
|
@jasmussen Perfect! Thanks for the icons! |
ellatrix
force-pushed
the
add/sub-sup-formats
branch
from
638474b
to
cb73f21
Compare
|
Wonderfull !. Regard. PS: how can we test or help ? |
|
Hey @piettt One way I usually help/test is to open PR's in gutenberg.run and add the PR number. It usually takes 3-4 tries before I am able to enter the site to test what the PR does. There I might take screenshots, or just in general see how something works and then give feedback. Do also join the WordPress slack #core-editor channel. See https://make.wordpress.org/core/ for more information. Have a great day! |
Description
Fixes #3507. Since rich text buttons are now in a collapsed dropdown list and not visible by default, it doesn't hurt to add these buttons, even if usage would be relatively low. The buttons represent semantic elements.
https://www.w3.org/TR/html52/textlevel-semantics.html#the-sub-and-sup-elements
Most editors have buttons for this, e.g. Google Docs:
How has this been tested?
Screenshots
Types of changes
Checklist: