Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-plugin: fix: Cannot find module '../utils' #21609

Merged
merged 1 commit into from
Apr 15, 2020
Merged

eslint-plugin: fix: Cannot find module '../utils' #21609

merged 1 commit into from
Apr 15, 2020

Conversation

curtisbelt
Copy link
Contributor

@curtisbelt curtisbelt commented Apr 15, 2020

Description

Added utils to package.json "files" list. Without this, utils folder is missing, and you get an error when trying to run eslint: Error: Failed to load plugin '@wordpress/eslint-plugin' declared in '.eslintrc.js': Cannot find module '../utils'

Fixes #21610

Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍

@aduth aduth merged commit 5459d77 into WordPress:master Apr 15, 2020
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Apr 15, 2020
@github-actions
Copy link

Congratulations on your first merged pull request, @curtisbelt! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 8.0 milestone Apr 15, 2020
@aduth
Copy link
Member

aduth commented Apr 15, 2020

I made a quick follow-up commit at f4c44cd to include a CHANGELOG entry for this fix, since it may be useful reference for those looking to upgrade after the fix is published.

@gziolo
Copy link
Member

gziolo commented Apr 15, 2020

The new version 5.0.1 of the package is out on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
3 participants