Fix editor shortcuts in Nav Menus page.#21338
Merged
Conversation
talldan
added
[Type] Bug
talldan
requested review from
adamziel,
draganescu,
noisysocks and
tellthemachines
|
Size Change: +4 B (0%) Total Size: 884 kB
ℹ️ View Unchanged
|
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
Testing this on Chrome/Mac, I'm seeing a few shortcuts that don't work:
- Save changes
- Undo changes
- Insert new block before selected
- Insert new block after selected
- When focused on the block in edit mode, Shift + Tab doesn't take me to the toolbar. It seems the only way to access the toolbar is with Option + F10.
Question: we wouldn't expect to be able to switch to code editor mode, would we?
Contributor
Author
|
@tellthemachines Yep, I think there are a few separate issues we'll have to fix, some separately:
I don't think that'd be possible, since these menus don't save as HTML. |
Member
If it's easy, go for it. If not, let's follow up on it later 🙂
I don't think we need undo/redo for our initial build of this screen. Remember, right now our goal is to build out something quick that lets us validate whether or not a block-based Navigation screen is a good idea. |
noisysocks
approved these changes
Apr 2, 2020
Contributor
Author
|
Thanks, working on the save shortcut in a separate PR. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renders the
BlockEditorKeyboardShortcutscomponent to ensure editor keyboard shortcuts work in the nav menus page.How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: