Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase severity of JSDoc to error. #20427

Merged
merged 9 commits into from
Mar 24, 2020
Merged

Increase severity of JSDoc to error. #20427

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8c21a7e
Update eslint-plugin-jsdoc.
sainthkh Feb 25, 2020
5262ce0
Fix lint errors.
sainthkh Mar 9, 2020
3d4e967
WP coding standard problem.
sainthkh Mar 3, 2020
c5e0a03
Turn off jsdoc/check-values.
sainthkh Mar 13, 2020
122b4ba
Revert the changed to WPLinkControlSettingsValue
sainthkh Mar 13, 2020
e95f1d6
Draft new coding standard for Record.
sainthkh Mar 13, 2020
3a61e08
Fix lint errors.
sainthkh Mar 13, 2020
ac32723
Update doc.
sainthkh Mar 13, 2020
ed598cd
Fix coding guideline
sainthkh Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint errors.
  • Loading branch information
@sainthkh
sainthkh committed Mar 19, 2020
commit 3a61e08de885d8ec5f140d2968e90991a58c5e1e
6 changes: 4 additions & 2 deletions packages/block-editor/src/components/block-preview/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,10 @@ import AutoHeightBlockPreview from './auto';
*
* @see https://github.com/WordPress/gutenberg/blob/master/packages/block-editor/src/components/block-preview/README.md
*
* @param {Array|Object} blocks A block instance (object) or an array of blocks to be previewed.
* @param {number} viewportWidth Width of the preview container in pixels. Controls at what size the blocks will be rendered inside the preview. Default: 700.
* @param {Object} preview options for how the preview should be shown
* @param {Array|Object} preview.blocks A block instance (object) or an array of blocks to be previewed.
* @param {number} preview.viewportWidth Width of the preview container in pixels. Controls at what size the blocks will be rendered inside the preview. Default: 700.
*
* @return {WPComponent} The component to be rendered.
*/
export function BlockPreview( {
Expand Down
2 changes: 2 additions & 0 deletions packages/url/src/is-url.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@
*/
import { URL } from 'react-native-url-polyfill';

/* eslint-disable jsdoc/valid-types */
/**
* @type {typeof import('./is-url').isURL}
*/
/* eslint-enable */
export function isURL( url ) {
// A URL can be considered value if the `URL` constructor is able to parse
// it. The constructor throws an error for an invalid URL.
Expand Down