Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wp-env: Add phpunit support #20090
Wp-env: Add phpunit support #20090
Changes from all commits
8c8777d
f3ff266
66651c5
5d10814
4027a0a
1670045
cab20b1
1da33f0
1c62809
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is working 🤔 -- at least not for me 🙁
This is the
readConfig
function, which is used byinit-config.js
to write thedocker-compose.yml
file (viabuild-docker-compose-config.js
). But AFAICS, none of those files evaluate the contents of theconfig
object. And if I check my~/wp-env/12345678/docker-compose.yml
, I don't see any of those config constants either. 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, the constants are not added to the docker compose config, but set with wp-cli:
gutenberg/packages/env/lib/wordpress.js
Lines 95 to 112 in 066d839
This function is called during
wp-env start