Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monorepo] fix unit tests #18608

Closed
wants to merge 2 commits into from
Closed

[Monorepo] fix unit tests #18608

wants to merge 2 commits into from

Conversation

dratwas
Copy link
Contributor

@dratwas dratwas commented Nov 19, 2019

Description

This is a part of migration gutenberg-mobile to gutenberg repo.

In this PR I fixed native unit tests.
I removed unused jest.config files and use configs from test/native directory

How has this been tested?

npm run native test should run all native tests and all of them should pass.

Types of changes

fix native tests after migration

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@dratwas dratwas added [Status] In Progress Tracking issues with work in progress [Type] Technical Prototype Offers a technical exploration into an idea as an example of what's possible labels Nov 19, 2019
@dratwas dratwas mentioned this pull request Nov 20, 2019
Merged
21 tasks
@dratwas dratwas removed the [Status] In Progress Tracking issues with work in progress label Nov 20, 2019
@dratwas dratwas marked this pull request as ready for review November 20, 2019 10:08
gziolo
gziolo reviewed Nov 26, 2019
View reviewed changes
.travis.yml Show resolved Hide resolved
@gziolo gziolo added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Nov 26, 2019
@Tug Tug mentioned this pull request Jan 16, 2020
Merged
@Tug Tug changed the title [Monorepo] fix unit tests [Monorepo] fix unit tests and linting Feb 3, 2020
@Tug Tug changed the title [Monorepo] fix unit tests and linting [Monorepo] fix unit tests Feb 3, 2020
@Tug
Copy link
Contributor

Tug commented Feb 28, 2020

Closing this one as unit tests are green since #18531 was merged and we will keep them this way for all future work that targets the feature branch.

@Tug Tug closed this Feb 28, 2020
@aristath aristath deleted the rnmobile/import-mobile-unit-tests branch November 10, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo left review comments

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Technical Prototype Offers a technical exploration into an idea as an example of what's possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dratwas @Tug @gziolo