Update: Default gradients #18214
Merged
Update: Default gradients #18214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
requested review from
ajitbohra,
ellatrix,
Soean,
talldan and
youknowriad
as code owners
|
I've got a bit on my plate today so unsure the details of the change. But just for the sake of making rebases simpler, this seems fine 👍 👍 What matters is we have two rows of gradient presets, the ones shown in #17603 (comment) and no more. Fine if the names change, fine if classnames change, fine if it takes a bit of PR juggling to make it eventually happen 😉 |
jorgefilipecosta
force-pushed
the
update/default-gradients
branch
from
ef3d775
to
fb643b5
Compare
jorgefilipecosta
force-pushed
the
update/default-gradients
branch
from
fb643b5
to
c80220c
Compare
daniloercoli
added a commit
that referenced
this pull request
Nov 5, 2019
…rnmobile/gb-mobile-872-JSApplicationIllegalArgumentException-in-RCTAztecView * 'master' of https://github.com/WordPress/gutenberg: (56 commits) Update: Default gradients. (#18214) Fix: setting a preset color on pullquote default style makes the block invalid (#18194) Fix default featured image size (#15844) Fix postmeta radio regression. (#18183) Components: Switch screen-reader-text to VisuallyHidden (#18165) [rnmobile] Release 1.16.0 to master (#18261) Template Loader: Add theme block template resolution. (#18247) Add a README file for storybook directory (#18245) Add editor-gradient-presets to get_theme_support (#17841) Add "Image Title Attribute" as an editable attribute on the image block (#11070) enables horizontal movers in social blocks (#18234) [RNMobile] Add mobile Spacer component (#17896) Add experimental `ResponsiveBlockControl` component (#16790) Fix mover for floats. (#18230) Rename Component to WPComponent in docstring (#18226) Colors Selector: replace `Aa` text by SVG icon (#18222) Removed gif from README (#18200) makes the submenu items stacked vertically (#18221) Add block navigator to sidebar panel for nav block (#18202) Fix: consecutive updates may trigger a blocks reset (#18219) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@jasmussen updated the default gradients in #17603. This change is not directly related to the custom gradients and makes rebasing hard.
I'm extracting this change to a separate PR, so both PR's are easier to review.
How has this been tested?
I verified the new gradients work as expected on the button and cover block.