-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental Link creation interface #17846
Commits on Oct 8, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 8dbc2bd - Browse repository at this point
Copy the full SHA 8dbc2bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee008be - Browse repository at this point
Copy the full SHA ee008beView commit details -
Configuration menu - View commit details
-
Copy full SHA for e685003 - Browse repository at this point
Copy the full SHA e685003View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70049ad - Browse repository at this point
Copy the full SHA 70049adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98e6aa5 - Browse repository at this point
Copy the full SHA 98e6aa5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85a6317 - Browse repository at this point
Copy the full SHA 85a6317View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ec1488 - Browse repository at this point
Copy the full SHA 8ec1488View commit details
Commits on Oct 9, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 140cc90 - Browse repository at this point
Copy the full SHA 140cc90View commit details -
Adds render prop to enable custom suggestions rendering
Previously it wasn’t possible to customise the render of the search suggestions. By providing an optional render prop we now have full control over this if required.
Configuration menu - View commit details
-
Copy full SHA for d64608e - Browse repository at this point
Copy the full SHA d64608eView commit details -
Update to utilise URLInput render prop to customise search suggestion…
…s render Previously we relied on our own render of suggestions but this wasn’t hooked up to all the accessibility enhancements afforded by URLInput. By utilising the render prop exposed by URLInput to customise the rendering of suggestions, we can have the best of both worlds.
Configuration menu - View commit details
-
Copy full SHA for 30e0eb6 - Browse repository at this point
Copy the full SHA 30e0eb6View commit details -
Update to add post type to the fetchLinkSuggestions responsive mapping
This is required to display the type of entitity in the search results for LinkControl
Configuration menu - View commit details
-
Copy full SHA for 53ce517 - Browse repository at this point
Copy the full SHA 53ce517View commit details -
Configuration menu - View commit details
-
Copy full SHA for b53c13c - Browse repository at this point
Copy the full SHA b53c13cView commit details -
Update suggestion render prop to provide component props as arguments
Previously when using the `renderSuggestions` render prop the user had to know how to put together the correct props on the correct elements in their custom render. By passing the default props for the listing element and the item element we can relieve the user of this burden by allowing them to spread the props onto the appropriate elements in their render without having to know how they are created.
Configuration menu - View commit details
-
Copy full SHA for 6d7259a - Browse repository at this point
Copy the full SHA 6d7259aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f32429 - Browse repository at this point
Copy the full SHA 4f32429View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4971e30 - Browse repository at this point
Copy the full SHA 4971e30View commit details
Commits on Oct 10, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 4aea19c - Browse repository at this point
Copy the full SHA 4aea19cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d554b65 - Browse repository at this point
Copy the full SHA d554b65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26c4c1b - Browse repository at this point
Copy the full SHA 26c4c1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e778a04 - Browse repository at this point
Copy the full SHA e778a04View commit details -
Update to allow URLs to be conditionally handled as a suggestion
Previously when a URL was entered it was deemed that no suggestions should or could be found and so the process of fetching suggestions was short circuited. Add additional prop to optionally allow developers to have URL-like values handled as suggestions.
Configuration menu - View commit details
-
Copy full SHA for 3ca482e - Browse repository at this point
Copy the full SHA 3ca482eView commit details -
Updates to conditionally use an entity or url based search results fe…
…tcher If the current value of the input is a URL then we conditionally pass a different handler for search results to the URLInput component. For URL based values we immediately return a “suggestion” object with values matching those entered by the user. Non URL based values are handled as previously.
Configuration menu - View commit details
-
Copy full SHA for aec9f39 - Browse repository at this point
Copy the full SHA aec9f39View commit details
Commits on Oct 11, 2019
-
Fix bug whereby fetchSearchSuggestions wasn’t called
Remove ambiguity by calling the search handler directly rather than proxying through another function and having to apply it immediately.
Configuration menu - View commit details
-
Copy full SHA for 70bd877 - Browse repository at this point
Copy the full SHA 70bd877View commit details -
Remove default toggle UI and implement Popover close
The LinkControl will be mostly where another element triggers the UI to appear. As a result we don’t want to force a toggle element on the developer. Rather we will expose an API to allow the consuming component to toggle the visibility of the LinkControl
Configuration menu - View commit details
-
Copy full SHA for 58220f8 - Browse repository at this point
Copy the full SHA 58220f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5eeb819 - Browse repository at this point
Copy the full SHA 5eeb819View commit details -
Configuration menu - View commit details
-
Copy full SHA for d355133 - Browse repository at this point
Copy the full SHA d355133View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2044065 - Browse repository at this point
Copy the full SHA 2044065View commit details -
Update to remove internal handling of open/closed state
This state is now expected to be handled by the consuming component chosing whether or not to render the component. It has no concept of open or closed.
Configuration menu - View commit details
-
Copy full SHA for b256d55 - Browse repository at this point
Copy the full SHA b256d55View commit details -
Configuration menu - View commit details
-
Copy full SHA for b55f557 - Browse repository at this point
Copy the full SHA b55f557View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2133fb1 - Browse repository at this point
Copy the full SHA 2133fb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70c5c04 - Browse repository at this point
Copy the full SHA 70c5c04View commit details -
Adds test which uncovers major bug in the implementation
Basically this test has revealed that due to the way we’re detecting and handling URL-like values the wrong data fetcher function gets passed to the URLInput component for the first input `change` event. For example if you paste `https://make.wordpress.com` directly into the input then it is determined to be a URL but because the current fetcher function for the current render is still the handler that deals with entity searches the correct results are not displayed. Adding another character to trigger a re-render will cause the UI to update to the expected state, but this is a major bug.
Configuration menu - View commit details
-
Copy full SHA for 4a031ed - Browse repository at this point
Copy the full SHA 4a031edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b5164c - Browse repository at this point
Copy the full SHA 5b5164cView commit details
Commits on Oct 14, 2019
-
Fix bug to make determining search handler use the latest input value
Previously we relied on parent component state to choose which search handler to use for the current input term. However, the state was always 1 tick behind so the previous search handler got used. Updating this to use the real time value of the input passed onChange ensures we select the correct search fetcher when the component re-renders.
Configuration menu - View commit details
-
Copy full SHA for 664daad - Browse repository at this point
Copy the full SHA 664daadView commit details -
Add loading spinner and associated test coverage
Spinner was technically always rendered but it wasn’t visible due to CSS styling. Fix and also cover with tests.
Configuration menu - View commit details
-
Copy full SHA for 9780959 - Browse repository at this point
Copy the full SHA 9780959View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c3bf35 - Browse repository at this point
Copy the full SHA 5c3bf35View commit details
Commits on Oct 15, 2019
-
Configuration menu - View commit details
-
Copy full SHA for c962dc6 - Browse repository at this point
Copy the full SHA c962dc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4c0a70 - Browse repository at this point
Copy the full SHA d4c0a70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cff4c2 - Browse repository at this point
Copy the full SHA 8cff4c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4a3f66 - Browse repository at this point
Copy the full SHA b4a3f66View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbe49e7 - Browse repository at this point
Copy the full SHA fbe49e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa0dd36 - Browse repository at this point
Copy the full SHA fa0dd36View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5a7e65 - Browse repository at this point
Copy the full SHA f5a7e65View commit details
Commits on Oct 16, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a88826e - Browse repository at this point
Copy the full SHA a88826eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec9e2ad - Browse repository at this point
Copy the full SHA ec9e2adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11ca79f - Browse repository at this point
Copy the full SHA 11ca79fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 779d440 - Browse repository at this point
Copy the full SHA 779d440View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4941bb8 - Browse repository at this point
Copy the full SHA 4941bb8View commit details -
Attempts to remove unwanted deps on other components. We now utilise Popover directly and suffer no consequences as we are not making use of any bespoke features provided by URLPopover.
Configuration menu - View commit details
-
Copy full SHA for 452ec55 - Browse repository at this point
Copy the full SHA 452ec55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5484a7c - Browse repository at this point
Copy the full SHA 5484a7cView commit details
Commits on Oct 17, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 37de5d9 - Browse repository at this point
Copy the full SHA 37de5d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba32148 - Browse repository at this point
Copy the full SHA ba32148View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33467f3 - Browse repository at this point
Copy the full SHA 33467f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 553be99 - Browse repository at this point
Copy the full SHA 553be99View commit details
Commits on Oct 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ad46c87 - Browse repository at this point
Copy the full SHA ad46c87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26c292f - Browse repository at this point
Copy the full SHA 26c292fView commit details
Commits on Oct 21, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 17be2f8 - Browse repository at this point
Copy the full SHA 17be2f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13f5ce1 - Browse repository at this point
Copy the full SHA 13f5ce1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 556088a - Browse repository at this point
Copy the full SHA 556088aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1cdd939 - Browse repository at this point
Copy the full SHA 1cdd939View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2588b9e - Browse repository at this point
Copy the full SHA 2588b9eView commit details -
Fix scroll shadows to use valid alpha transparent values in gradient
Fixes broken shadows in Safari which didn’t recognise transparent as a value to transition to in a gradient.
Configuration menu - View commit details
-
Copy full SHA for a065936 - Browse repository at this point
Copy the full SHA a065936View commit details
Commits on Oct 23, 2019
-
Adds instructional text in place of URL for suggestions that are URLs
Addresses designer feedback #17557 (comment)
Configuration menu - View commit details
-
Copy full SHA for 98836fd - Browse repository at this point
Copy the full SHA 98836fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5254015 - Browse repository at this point
Copy the full SHA 5254015View commit details -
Configuration menu - View commit details
-
Copy full SHA for 811ad11 - Browse repository at this point
Copy the full SHA 811ad11View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cd6d18 - Browse repository at this point
Copy the full SHA 9cd6d18View commit details -
Updates key to avoid usage of index
We cannot assume the suggestion `id` will be unique. This is because at the moment the search results are `Post`s. However in the future we may also need to include `Category` terms and the term IDs could easily clash with the Post IDs as they are in different DB tables. Using the `type` to differentiate the key. Addresses #17846 (comment)
Configuration menu - View commit details
-
Copy full SHA for bdb6217 - Browse repository at this point
Copy the full SHA bdb6217View commit details -
Configuration menu - View commit details
-
Copy full SHA for d0a348b - Browse repository at this point
Copy the full SHA d0a348bView commit details -
Configuration menu - View commit details
-
Copy full SHA for da212f0 - Browse repository at this point
Copy the full SHA da212f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19d5e64 - Browse repository at this point
Copy the full SHA 19d5e64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 548279b - Browse repository at this point
Copy the full SHA 548279bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a844800 - Browse repository at this point
Copy the full SHA a844800View commit details
Commits on Oct 24, 2019
-
Configuration menu - View commit details
-
Copy full SHA for fd3a6ef - Browse repository at this point
Copy the full SHA fd3a6efView commit details -
Configuration menu - View commit details
-
Copy full SHA for b314c49 - Browse repository at this point
Copy the full SHA b314c49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5aeb531 - Browse repository at this point
Copy the full SHA 5aeb531View commit details -
Updates to display the URL type in the search results
Previously only true `http` URLs were formatted with the correct type and the instructional text. Fixes so that all types of manual URL entry are correctly shown as such in the search results. Adds test to cover mailto variant of this.
Configuration menu - View commit details
-
Copy full SHA for 1a7c285 - Browse repository at this point
Copy the full SHA 1a7c285View commit details -
Refactor tests to assert against all valid protocol formats and link …
…variants This now includes tel, mailto and internal links.
Configuration menu - View commit details
-
Copy full SHA for 63201c9 - Browse repository at this point
Copy the full SHA 63201c9View commit details -
Adds test to cover display of fallback URL search result for search v…
…alues that are potentially URLS
Configuration menu - View commit details
-
Copy full SHA for 4918184 - Browse repository at this point
Copy the full SHA 4918184View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd29ab5 - Browse repository at this point
Copy the full SHA cd29ab5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d8befb - Browse repository at this point
Copy the full SHA 2d8befbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d8895d5 - Browse repository at this point
Copy the full SHA d8895d5View commit details -
link-control: delegate handling keydown event
Instead of this, let's propagate the onKeyDown and onKeyPress events to the parent component
Configuration menu - View commit details
-
Copy full SHA for 2413016 - Browse repository at this point
Copy the full SHA 2413016View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3042c8 - Browse repository at this point
Copy the full SHA e3042c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a9d558 - Browse repository at this point
Copy the full SHA 0a9d558View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89e92fb - Browse repository at this point
Copy the full SHA 89e92fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff57160 - Browse repository at this point
Copy the full SHA ff57160View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48e5f44 - Browse repository at this point
Copy the full SHA 48e5f44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e811db - Browse repository at this point
Copy the full SHA 4e811dbView commit details -
Update to render with a “current link” if one is provided.
Previously if you passed in a current link the component would still render with a search box as thought nothing was selected. Updates so that if `currentLink` is provided the UI reflects that by showing the “selected” item and no search input.
Configuration menu - View commit details
-
Copy full SHA for 43c30b2 - Browse repository at this point
Copy the full SHA 43c30b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 158ea3e - Browse repository at this point
Copy the full SHA 158ea3eView commit details
Commits on Oct 25, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 4981a71 - Browse repository at this point
Copy the full SHA 4981a71View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1c54a6 - Browse repository at this point
Copy the full SHA f1c54a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 797fd6c - Browse repository at this point
Copy the full SHA 797fd6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5e44e6 - Browse repository at this point
Copy the full SHA e5e44e6View commit details -
Add test to cover keyboard handling
Note: this uncovered a bug whereby keyboard handling of “selecting” the link you want to use is broken. This needs to be fixed.
Configuration menu - View commit details
-
Copy full SHA for 5ba4b65 - Browse repository at this point
Copy the full SHA 5ba4b65View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5abad2 - Browse repository at this point
Copy the full SHA d5abad2View commit details -
Fix URLInput to pass the actual suggestion object not the index
If the full object is not provided then consuming components have no way of accessing the details of the selected suggestion thereby rendering it useless.
Configuration menu - View commit details
-
Copy full SHA for 5c1ec22 - Browse repository at this point
Copy the full SHA 5c1ec22View commit details -
Fix keyboard handling so hitting
ENTER
will select an item as the c……urrent link Builds on previous commit.
Configuration menu - View commit details
-
Copy full SHA for 4d5b455 - Browse repository at this point
Copy the full SHA 4d5b455View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8a01bd - Browse repository at this point
Copy the full SHA b8a01bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7df9aa5 - Browse repository at this point
Copy the full SHA 7df9aa5View commit details -
Fix missing key prop regression
Previously `buildSuggestionItemProps` was including a key. However the implementation of `LinkControl` changed so that this was not required. However we forgot to reinstate on `URLInput`. This update ensures a key prop is set on the default output. Note that disabling of the autofocus linting was already in place: https://github.com/WordPress/gutenberg/blob/04e142e9cbd06a45c4ea297ec573d389955c13be/packages/block-editor/src/components/url-input/index.js#L239 Addresses #17846 (comment)
Configuration menu - View commit details
-
Copy full SHA for b6edb73 - Browse repository at this point
Copy the full SHA b6edb73View commit details -
Configuration menu - View commit details
-
Copy full SHA for b435b49 - Browse repository at this point
Copy the full SHA b435b49View commit details
Commits on Oct 28, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 8c5ed79 - Browse repository at this point
Copy the full SHA 8c5ed79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fffe8e - Browse repository at this point
Copy the full SHA 1fffe8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c1614d - Browse repository at this point
Copy the full SHA 1c1614dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cdf706 - Browse repository at this point
Copy the full SHA 0cdf706View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f80347 - Browse repository at this point
Copy the full SHA 2f80347View commit details -
Mark Link Creation Interface as Experimental (#18110)
* mark main component as experimental * mark new URLInput props as experimental * add experimental onKeyPress * remove key handlers * Updates to use alias on experimental props Addresses #18110 (comment)
Configuration menu - View commit details
-
Copy full SHA for b93a0db - Browse repository at this point
Copy the full SHA b93a0dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b6715d - Browse repository at this point
Copy the full SHA 5b6715dView commit details
Commits on Oct 29, 2019
-
Update props ordering and readme docs
Also fixes eslint errors that kept me from committing the original changes
Configuration menu - View commit details
-
Copy full SHA for 280db32 - Browse repository at this point
Copy the full SHA 280db32View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba985eb - Browse repository at this point
Copy the full SHA ba985ebView commit details -
Rename InputSearch to SearchInput
Props @talldan I really hope those changes I had to make in `search-input.js` don't break anything.
Configuration menu - View commit details
-
Copy full SHA for 7d35791 - Browse repository at this point
Copy the full SHA 7d35791View commit details
Commits on Oct 30, 2019
-
Configuration menu - View commit details
-
Copy full SHA for e7585b8 - Browse repository at this point
Copy the full SHA e7585b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8450bb1 - Browse repository at this point
Copy the full SHA 8450bb1View commit details