-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track and report test coverage #1783
Conversation
.gitignore
Outdated
.DS_Store | ||
.vscode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see .vscode
was already here and this is just moving its location, though should it really be here in the first place?
Via #1382 (comment) from a couple of days ago:
IDE specific entries in
.gitignore
should not be in the repo, users should manage these locally in~/.gitignore_global
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Originally added in #294.
Coveralls comments and notifications can get noisy, I think turning off comments and changing the failure threshold to 5% would be something we should do: Via https://coveralls.io/github/WordPress/gutenberg/settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
TODO: Use `WordPress/gutenberg/master.svg` instead of `WordPress/gutenberg.svg` (all branches)
Maybe so. However, coverage is at 18%. Eighteen percent. This shows that we are not developing with testing in mind. So I'd like to leave this enabled for a while. |
Changes Unknown when pulling 3a1cc23 on add/coverage-badge into ** on master**. |
Changes Unknown when pulling 3a1cc23 on add/coverage-badge into ** on master**. |
With these changes, local testing and Travis testing don't produce the same result. You can see that running |
Hmm, actually, |
Use Jest code coverage added in #1382 (with some tweaks/improvements in this PR to ignore built files, Storybook stories, etc.) and coveralls.io and
node-coveralls
for reporting coverage during Travis CI builds.