Document server functions in block style variations section#16997
Merged
jorgefilipecosta merged 16 commits intomasterfrom Aug 20, 2019
Conversation
jorgefilipecosta
requested review from
ajitbohra,
chrisvanpatten,
mkaz and
youknowriad
as code owners
jorgefilipecosta
added
[Type] Developer Documentation
chrisvanpatten
previously requested changes
Aug 11, 2019
Contributor
chrisvanpatten
left a comment
chrisvanpatten
left a comment
There was a problem hiding this comment.
A smattering of tweaks, but this is awesome. Thanks for documenting it 🔥
jorgefilipecosta
force-pushed
the
update/expand-the-block-style-variations-documentation-to-document-server-functions
branch
2 times, most recently
from
4f22ecc to
144f7cf
Compare
Member
Author
|
Hi @chrisvanpatten thank you a lot for the review and the suggestions. All your suggestions were applied. |
jorgefilipecosta
dismissed
chrisvanpatten’s stale review
Suggestions were applied
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
jorgefilipecosta
force-pushed
the
update/expand-the-block-style-variations-documentation-to-document-server-functions
branch
from
144f7cf to
c371a74
Compare
youknowriad
approved these changes
Aug 20, 2019
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
It's weird that this page is called "Block Filters". It's about Block Extensibility in general I think?
Anyway, separate question.
LGTM 👍
jorgefilipecosta
deleted the
update/expand-the-block-style-variations-documentation-to-document-server-functions
branch
donmhico
pushed a commit
to donmhico/gutenberg
that referenced
this pull request
Aug 27, 2019
…s#16997) * Expand the block style variations documentation to document server functions * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Fix line break and code block closing
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
* Expand the block style variations documentation to document server functions * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Fix line break and code block closing
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
* Expand the block style variations documentation to document server functions * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Update docs/designers-developers/developers/filters/block-filters.md Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com> * Fix line break and code block closing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR documents the server-side functions register_block_style and un register_block_style added in #16356 inside the block style variations section.