RichText 🧹 (clean up, move Autocomplete, remove DOM dependency)

[ellatrix]

I renamed this branch because @frontdevde had problems pulling Gutenberg because of the emoji in the branch name.

Description

This PR mostly moves code around.

• Move Autocomplete to the RichText wrapper with block context.
• Properly convert the multiline prop to a multilineTag.
• Use the rich text value to determine when to merge. This removes the dependency on the DOM package.
• Split onKeyDown in multiple functions.
• Reduce code indentation (in one occasion 5 → 2 tabs).

How has this been tested?

E2e tests should pass.

Screenshots

Types of changes

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.

[gziolo]

This PR still needs to be rebased after some changes applied to master.

I tested a few blocks including Paragraph, Galler and List toghether with the autocompletion and everything works as expected.

I'm not fully skilled to process all changes around new onKeyDown implementation in the rich-text/src/component/index.js so you might want to ask someone else to focus on that part.

[ellatrix]

I'm not fully skilled to process all changes around new onKeyDown implementation in the rich-text/src/component/index.js so you might want to ask someone else to focus on that part.-

I'm not sure who else would be more skilled. I merely moved some code around and sorted it by keyCode. The only change I made that is not just moving code around is swapping ! isHorizontalEdge, which uses the DOM, with

activeFormats.length ||
( isReverse && start !== 0 ) ||
( ! isReverse && end !== text.length )

so that we use the internal rich text value instead of the DOM to determine when to merge/delete.

It's the same thing.

Since we're at the start of a release cycle, I'll merge this now, so we can continue work on top of this, and there is enough time to catch problems if any appear.