Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to skip NVM installation in setup-local-env.sh #16248

Closed
wants to merge 4 commits into from
Closed

Allow to skip NVM installation in setup-local-env.sh #16248

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d93bbcb
Allow to skip NVM installation in setup-local-env.sh
desaiuditd Jun 23, 2019
bdef063
Remove the bash command to shift processed flags in setup script.
desaiuditd Jun 24, 2019
081c758
Trigger Travis
desaiuditd Jun 25, 2019
9a2decc
Merge branch 'master' into add/allow-to-skip-nvm-installation-in-loca…
desaiuditd Jul 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove the bash command to shift processed flags in setup script. 
This was not needed, as each script is sourced explicitly in the current shell. So it will take its own arguments.
This will also fix the Travis CI timeout.
  • Loading branch information
@desaiuditd
desaiuditd committed Jun 24, 2019
commit bdef06312fce890830a2b8da2828321059e6cfa2
2 changes: 1 addition & 1 deletion bin/bootstrap-env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ while getopts ":-:" opt; do
esac;;
esac
done
shift $((OPTIND - 1))