ESLint: Copy no-restricted-syntax rules from ESLint plugin to config file

[tfrommen]

Description

As discussed in #15839, this PR copies the custom rules/options to the Gutenberg ESLint config.

How has this been tested?

Create a file test.js with this content:

const { __experimentalGetSettings } = wp.date;
const { __, _n, _nx, _x } = wp.i18n;

const foo_x = () => {};

const foo = 'bar';

/**
 * Should NOT flag
 */
__( 'Some text', 'text-domain' );
_n( 'Some text', 'Some texts', 42, 'text-domain' );
_nx( 'Some text', 'Some texts', 42, 'Some context', 'text-domain' );
_x( 'Some text', 'Some context', 'text-domain' );
const settings = __experimentalGetSettings();
foo_x();

/**
 * SHOULD flag
 */
__( foo, 'text-domain' );
_n( foo, 'Some texts', 42, 'text-domain' );
_nx( foo, 'Some texts', 42, 'Some context', 'text-domain' );
_x( foo, 'Some context', 'text-domain' );

_n( 'Some text', foo, 42, 'text-domain' );
_nx( 'Some texts', foo, 42, 'Some context', 'text-domain' );
_x( 'Some text', foo, 'text-domain' );

_nx( 'Some text', 'Some texts', 42, foo, 'text-domain' );

Then call:

./node_modules/.bin/eslint test.js

Types of changes

Copy ESLint rules/options that are defined in the ESLint plugin, but overriden in the Gutenberg ESLint config.

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.

[gziolo]

Thanks for wrangling it. Let's merge when Travis is green.

[gziolo]

That's surprising, it should error in master...

[swissspidy]

$ ./node_modules/.bin/eslint .eslintrc.js

/Users/pascalb/Workspace/WordPress/gutenberg/.eslintrc.js
  0:0  warning  File ignored by default.  Use a negated ignore pattern (like "--ignore-pattern '!<relative/path/to/filename>'") to override

✖ 1 problem (0 errors, 1 warning)

That explains it :-)

[tfrommen]

I was wondering the same, but reason is that the .eslintrc.js file is, by default, ignored. So ESLint doesn't check it.

[gziolo]

Nice, good to know 😃

[aduth]

I was wondering the same, but reason is that the .eslintrc.js file is, by default, ignored. So ESLint doesn't check it.

Can we change this? Not immediately obvious why we'd want it to be exempt.

[tfrommen]

@aduth sure, I'll create a PR for that. See #15887.