Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/slot fill docs #15798

Merged
merged 55 commits into from
May 23, 2019
Merged

Conversation

ryanwelcher
Copy link
Contributor

Description

This PR addresses incorrect image path issues when SlotFill is rendered in the handbook.

Example: https://developer.wordpress.org/block-editor/developers/slotfills/plugin-block-settings-menu-item/

Ryan Welcher and others added 30 commits October 25, 2018 16:47
Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
@ryanwelcher
Copy link
Contributor Author

Closes #15744

@ryanwelcher
Copy link
Contributor Author

ryanwelcher commented May 23, 2019

@nosolosw looks like my image paths were incorrect. I've pushed a change to this branch to address that.

Copy link
Member

@oandregal oandregal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround.

@oandregal oandregal merged commit e91dc28 into WordPress:master May 23, 2019
@oandregal oandregal added the [Type] Bug An existing feature does not function as intended label May 23, 2019
@oandregal
Copy link
Member

@ryanwelcher the docs need updating. Would you have the availability to prepare a PR to add a section on how to add images to the handbook?

@youknowriad youknowriad added this to the 5.8 (Gutenberg) milestone May 24, 2019
@ryanwelcher ryanwelcher deleted the update/slot-fill-docs branch May 24, 2019 12:07
@ryanwelcher
Copy link
Contributor Author

@nosolosw I created an issue for that #15811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants