Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Picker and BottomSheet to the @wordpress/components package #15750

Merged
merged 1 commit into from
May 23, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/block-editor/src/components/index.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,3 @@ export { default as DefaultBlockAppender } from './default-block-appender';

// State Related Components
export { default as BlockEditorProvider } from './provider';

// Mobile Editor Related Components
export { default as BottomSheet } from './mobile/bottom-sheet';
export { default as Picker } from './mobile/picker';
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
* WordPress dependencies
*/
import { __ } from '@wordpress/i18n';
import { Picker } from '@wordpress/block-editor';
import { Picker } from '@wordpress/components';

export const MEDIA_TYPE_IMAGE = 'image';
export const MEDIA_TYPE_VIDEO = 'video';
Expand Down

This file was deleted.

2 changes: 1 addition & 1 deletion packages/block-library/src/image/edit.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import { isEmpty } from 'lodash';
* WordPress dependencies
*/
import {
BottomSheet,
Toolbar,
ToolbarButton,
} from '@wordpress/components';
Expand All @@ -25,7 +26,6 @@ import {
RichText,
BlockControls,
InspectorControls,
BottomSheet,
} from '@wordpress/block-editor';
import { __, sprintf } from '@wordpress/i18n';
import { isURL } from '@wordpress/url';
Expand Down
4 changes: 4 additions & 0 deletions packages/components/src/index.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,7 @@ export { default as withFocusOutside } from './higher-order/with-focus-outside';
export { default as withFocusReturn } from './higher-order/with-focus-return';
export { default as withNotices } from './higher-order/with-notices';
export { default as withSpokenMessages } from './higher-order/with-spoken-messages';

// Mobile Components
export { default as BottomSheet } from './mobile/bottom-sheet';
export { default as Picker } from './mobile/picker';
30 changes: 30 additions & 0 deletions packages/components/src/mobile/bottom-sheet/button.native.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
/**
* External dependencies
*/
import { TouchableOpacity, View, Text } from 'react-native';

/**
* Internal dependencies
*/
import styles from './styles.scss';

const BottomSheetButton = ( {
onPress,
disabled,
text,
color,
} ) => (
<TouchableOpacity
accessible={ true }
onPress={ onPress }
disabled={ disabled }
>
<View style={ { flexDirection: 'row', justifyContent: 'center' } }>
<Text style={ { ...styles.buttonText, color } }>
{ text }
</Text>
</View>
</TouchableOpacity>
);

export default BottomSheetButton;
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { __, _x, sprintf } from '@wordpress/i18n';
import styles from './styles.scss';
import platformStyles from './cellStyles.scss';

export default class Cell extends Component {
export default class BottomSheetCell extends Component {
constructor( props ) {
super( ...arguments );
this.state = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import Cell from './cell';
import Picker from '../picker';

export default function PickerCell( props ) {
export default function BottomSheetPickerCell( props ) {
const {
options,
onChangeValue,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { __, _x, sprintf } from '@wordpress/i18n';
*/
import Cell from './cell';

export default function SwitchCell( props ) {
export default function BottomSheetSwitchCell( props ) {
const {
value,
onValueChange,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@ import { View } from 'react-native';
*/
import { __ } from '@wordpress/i18n';
import { Component } from '@wordpress/element';
import { BottomSheet } from '@wordpress/block-editor';

/**
* Internal dependencies
*/
import BottomSheet from '../bottom-sheet';

export default class Picker extends Component {
constructor() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,18 @@ class Picker extends Component {
const labels = options.map( ( { label } ) => label );
const fullOptions = [ __( 'Cancel' ) ].concat( labels );

ActionSheetIOS.showActionSheetWithOptions( {
options: fullOptions,
cancelButtonIndex: 0,
},
( buttonIndex ) => {
if ( buttonIndex === 0 ) {
return;
}
const selected = options[ buttonIndex - 1 ];
onChange( selected.value );
},
ActionSheetIOS.showActionSheetWithOptions(
{
options: fullOptions,
cancelButtonIndex: 0,
},
( buttonIndex ) => {
if ( buttonIndex === 0 ) {
return;
}
const selected = options[ buttonIndex - 1 ];
onChange( selected.value );
},
);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/format-library/src/link/modal.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ import { Platform } from 'react-native';
*/
import { __ } from '@wordpress/i18n';
import { Component } from '@wordpress/element';
import { BottomSheet } from '@wordpress/block-editor';
import { prependHTTP } from '@wordpress/url';
import {
BottomSheet,
withSpokenMessages,
} from '@wordpress/components';
import {
Expand Down