Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Calendar block icon for better alignment with the Archives block icon #15628

Merged
merged 3 commits into from
May 16, 2019

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented May 14, 2019

The current Calendar block icon uses the Calendar Dashicon, which is stylistically different from the Calendar used in the Archives block. To better align these, I suggest we adopt the calendar_today icon from Material to represent the calendar block.

Alternatively, to separate these two icons visually, we could use the current "Archives" icon for the Calendar block instead, and explore a new icon for the Archives block — Perhaps the history, book, or library_book icons?


Before:

Screen Shot 2019-05-14 at 9 32 47 AM

After:

Screen Shot 2019-05-14 at 9 30 24 AM

@kjellr kjellr added Needs Design Feedback Needs general design feedback. [Block] Calendar Affects the Calendar Block labels May 14, 2019
@kjellr kjellr requested review from mapk and jasmussen May 14, 2019 13:40
@kjellr kjellr self-assigned this May 14, 2019
Copy link
Member

@Soean Soean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works in inserter and block.

@kjellr kjellr requested a review from melchoyce May 14, 2019 13:57
@sarahmonster
Copy link
Member

From a design perspective, this definitely feels like an improvement! 👍

For reference, this is the Calendar block:
Screenshot 2019-05-14 at 20 40 12

...and this is the Archive block:
Screenshot 2019-05-14 at 20 40 21

Given the obvious visual difference betweeen these two blocks, it might be a good idea to consider representing that difference in the icons we use. The Archive icon seems to be a better representation of the Calendar block here, in terms of visual appearance and output. From the existing Material library, the library_book definitely feels like the closest choice, but it still doesn't immediately feel as though it fits.

What about something like list_alt? Or maybe a list inside a calendar, to communicate the idea of a list of past posts?

@melchoyce
Copy link
Contributor

From the existing Material library, the library_book definitely feels like the closest choice, but it still doesn't immediately feel as though it fits.

I thought the same, it felt closest of the bunch.

There's a lot of filing boxes here: https://www.iconfinder.com/search/?q=archive

We could create a custom icon, maybe like this:

image

@kjellr
Copy link
Contributor Author

kjellr commented May 14, 2019

What about something like list_alt? Or maybe a list inside a calendar, to communicate the idea of a list of past posts?

list-alt almost makes sense, but I know we're actually considering using it for another control in the UI. 😄

The list inside of a calendar may work:

Screen Shot 2019-05-14 at 4 25 37 PM

@melchoyce the middle one's just like your example above, but I added back the tabs at the top so it looks less like a web browser.

@davewhitley
Copy link
Contributor

davewhitley commented May 14, 2019

Archive:

example from Gridicons

Screen Shot 2019-05-14 at 3 17 17 PM

Ones that might work from Material

Screen Shot 2019-05-14 at 3 23 03 PM
Screen Shot 2019-05-14 at 3 22 22 PM
Screen Shot 2019-05-14 at 3 21 24 PM
Screen Shot 2019-05-14 at 3 21 21 PM
Screen Shot 2019-05-14 at 3 20 50 PM
Screen Shot 2019-05-14 at 3 20 44 PM

Use the old Archives icon for the Calendar block, add a new icon to the Archives block.
@kjellr
Copy link
Contributor Author

kjellr commented May 15, 2019

Thanks for the feedback folks. I've updated the PR like so:

  • I've updated the Calendar icon to use the old Archives block icon.
  • I've added a new icon to the Archives block. I went with the "List inside of a calendar" option for now, but happy to refresh with one of the other options discussed. This one made sense to me right now: the archives block is basically a calendar, but displayed in a list form. This icon helps both blocks share the same visual language, which is kind of cool. Maybe they're too similar though?

Screen Shot 2019-05-15 at 12 37 47 PM

Let me know what you all think!

@mapk
Copy link
Contributor

mapk commented May 15, 2019

:shipit: Looks good Kjell!

Copy link
Contributor

@mapk mapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Dropped a proper review. 😉

@kjellr
Copy link
Contributor Author

kjellr commented May 16, 2019

Thanks, folks!

@kjellr kjellr merged commit b6dcb20 into master May 16, 2019
@kjellr kjellr deleted the update/calendar-block-icon branch May 16, 2019 12:32
@kjellr kjellr added this to the 5.8 (Gutenberg) milestone May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Calendar Affects the Calendar Block Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants