-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Calendar block icon for better alignment with the Archives block icon #15628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and works in inserter and block.
From a design perspective, this definitely feels like an improvement! 👍 For reference, this is the Calendar block: ...and this is the Archive block: Given the obvious visual difference betweeen these two blocks, it might be a good idea to consider representing that difference in the icons we use. The Archive icon seems to be a better representation of the Calendar block here, in terms of visual appearance and output. From the existing Material library, the What about something like list_alt? Or maybe a list inside a calendar, to communicate the idea of a list of past posts? |
I thought the same, it felt closest of the bunch. There's a lot of filing boxes here: https://www.iconfinder.com/search/?q=archive We could create a custom icon, maybe like this: |
The list inside of a calendar may work: @melchoyce the middle one's just like your example above, but I added back the tabs at the top so it looks less like a web browser. |
Use the old Archives icon for the Calendar block, add a new icon to the Archives block.
Thanks for the feedback folks. I've updated the PR like so:
Let me know what you all think! |
Looks good Kjell! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped a proper review. 😉
Thanks, folks! |
The current Calendar block icon uses the Calendar Dashicon, which is stylistically different from the Calendar used in the Archives block. To better align these, I suggest we adopt the
calendar_today
icon from Material to represent the calendar block.Alternatively, to separate these two icons visually, we could use the current "Archives" icon for the Calendar block instead, and explore a new icon for the Archives block — Perhaps the
history
,book
, orlibrary_book
icons?Before:
After: