Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword design review for clarity #15611

Merged
merged 1 commit into from
May 17, 2019
Merged

Reword design review for clarity #15611

merged 1 commit into from
May 17, 2019

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented May 13, 2019

Description

Update design review guidelines for a PR.
Hopefully clarifies confusion around what should be submitted for design review.

Fixes #15174

Types of changes

Documentation. View on branch here

Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible typo here on repository-management.md
3 participants