Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a note about the Github teams to the repository management docs #15595

Merged
merged 5 commits into from
May 16, 2019

Conversation

youknowriad
Copy link
Contributor

Everything is in the title.

@youknowriad youknowriad added [Type] Developer Documentation Documentation for developers [Type] Project Management Meta-issues related to project management of Gutenberg labels May 13, 2019
@youknowriad youknowriad self-assigned this May 13, 2019
Copy link
Contributor

@nerrad nerrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have something about the teams in the doc. However, based on the description, its appears that the Gutenberg team is just a distinction type team (i.e. you've meaningfully contributed to 2/3 of the project here's a badge). I'm assuming that's not the case, so could the purpose of the Gutenberg team be expanded a bit?

Also, I think there's potential for confusion between the two teams, should the names given the teams be more distinctive?

@youknowriad
Copy link
Contributor Author

I'm not great at writing docs :). The gutenberg team is also about having access to the repository (labeling, creating branches, avoid working on forks.

I think it's too late to change branches and we also can't avoid "gutenberg" in the team names as the teams are global to the WordPress org.

If anyone is willing to give this a stab and clarify more, please do.

@gziolo
Copy link
Member

gziolo commented May 13, 2019

i.e. you've meaningfully contributed to 2/3 of the project here's a badge

I think the idea is 2 or 3 PRs merged with the help of the contributor to be promoted to member :)

Gutenberg Core team is a subset of Gutenberg team which gives you some additional capabilities. One of them is that you get notified when someone uses (at)WordPress/gutenberg-core. It's a great way to bring the attention of the core team member in PRs or issues which need some technical guidance. The other use case I personally find rarely useful is the ability to force-push PR even when Travis is not green or to push directly to master. There are some justifications (fix broken tests, do Lerna publish) to do it even though in general it's considered a very bad practice.

Copy link
Contributor

@chrisvanpatten chrisvanpatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nits but overall nice to have this clarification!

docs/contributors/repository-management.md Outdated Show resolved Hide resolved
docs/contributors/repository-management.md Outdated Show resolved Hide resolved
youknowriad and others added 2 commits May 13, 2019 17:01
Co-Authored-By: Chris Van Patten <hello@chrisvanpatten.com>
Co-Authored-By: Chris Van Patten <hello@chrisvanpatten.com>
docs/contributors/repository-management.md Outdated Show resolved Hide resolved
docs/contributors/repository-management.md Outdated Show resolved Hide resolved
youknowriad and others added 2 commits May 15, 2019 10:04
Co-Authored-By: Andrew Duthie <andrew@andrewduthie.com>
Co-Authored-By: Andrew Duthie <andrew@andrewduthie.com>
Copy link
Contributor

@mapk mapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Riad! Thanks for writing this up. :shipit:

Copy link
Contributor

@nerrad nerrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now. Let's get this merged.

@youknowriad youknowriad merged commit e2d5432 into master May 16, 2019
@youknowriad youknowriad deleted the add/teams-documentation branch May 16, 2019 10:04
@gziolo gziolo added this to the 5.8 (Gutenberg) milestone May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers [Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants